Fix videoplayback on NC15 #68
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@MorrisJobke can you test safari |
| return $.getScript(scriptPath, function (xhr) {eval(xhr);}); | ||
| var scriptPath = OC.filePath('files_videoplayer', 'js', 'videojs/video.js'); | ||
|
|
||
| var deferred = $.Deferred(); |
There was a problem hiding this comment.
this is duplicating https://github.com/nextcloud/server/blob/b7767a51f140d3f588278f053f3a9e1eb84e4346/core/js/js.js#L364-L385, isn't it? Does $.getScript load the script differently?
There was a problem hiding this comment.
Yes. I have no idea why or how but it is different. With $.getScript I did not have a videojs funtion after loading. This way i do.
There was a problem hiding this comment.
@ChristophWurst but it probably would make sense to look into a generic approach here indeed. This is just the quick fix for 15.
There was a problem hiding this comment.
I see, they are indeed a bit different. Let's use this fix for 15 now and look into a proper npm setup for 16 where we can use dependabot and video.js from https://www.npmjs.com/package/video.js.
There was a problem hiding this comment.
We could integrate that with the slideshow/big picture we discussed in nextcloud/server#12382
There was a problem hiding this comment.
Yeah, sounds good. So let's npm'ize this repo for 16, switch to Vue and use a standardized component for the overlay.
|
Thanks a lot for fixing this @rullzer! 🎉 |
No description provided.