Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove old unused code #1108

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: Remove old unused code #1108

merged 1 commit into from
Feb 28, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 27, 2024

Most parts of the controller are no longer used, so remove it.

@susnux susnux added this to the Nextcloud 29 milestone Feb 27, 2024
come-nc
come-nc reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you need to remove the route as well, no?

@susnux susnux force-pushed the fix/drop-old-code branch 2 times, most recently from 705110a to f5477ad Compare February 27, 2024 13:05
@susnux
Copy link
Contributor Author

susnux commented Feb 27, 2024

Then you need to remove the route as well, no?

@come-nc yes noticed this too and pushed the change :)

@susnux susnux requested a review from come-nc February 27, 2024 13:05
@nickvergessen nickvergessen removed their request for review February 27, 2024 14:25
@susnux
fix: Remove old unused code
66575b8 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
szaimen
szaimen approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux merged commit 3d6075c into master Feb 28, 2024
46 checks passed
@susnux susnux deleted the fix/drop-old-code branch February 28, 2024 10:26
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
3. to review feedback-requested
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @szaimen @come-nc