Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not mess with all NcModal styles - scope styles to wizard #1164

Merged
merged 2 commits into from
Apr 13, 2024
Merged

fix: Do not mess with all NcModal styles - scope styles to wizard #1164

merged 2 commits into from
Apr 13, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 12, 2024

We need to scope styles otherwise all modals on Nextcloud will be displayed incorrectly.

@susnux
Copy link
Contributor Author

susnux commented Apr 12, 2024

/backport to stable29

@nickvergessen
Copy link
Member

The media thing is still global?🤔

@susnux
fix: Do not mess with all NcModal styles - scope styles to wizard
82734d9 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/dont-mess-with-global-styles branch from f5538ab to 82734d9 Compare April 12, 2024 21:54
@susnux
Copy link
Contributor Author

susnux commented Apr 13, 2024

/compile

@nextcloud-command
chore(assets): Recompile assets
c119a18 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 4fc9c28 into master Apr 13, 2024
39 checks passed
@susnux susnux deleted the fix/dont-mess-with-global-styles branch April 13, 2024 07:59
@backportbot backportbot bot mentioned this pull request Apr 13, 2024
Merged
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen Awaiting requested review from szaimen

@emoral435 emoral435 Awaiting requested review from emoral435

Assignees
No one assigned
Labels
3. to review bug feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@susnux @nickvergessen @Pytal @ShGKme @nextcloud-command