-
Notifications
You must be signed in to change notification settings - Fork 58
Fixed gallery button insertion script and design fix #336
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Ouuuups, let me fix it |
When testing, it's important to also try with public shares as the layout is completely different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs more work - I'll add notes in a separate comment
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -29,8 +29,12 @@ div.crumb.last a { | |||
width: 40px; | |||
} | |||
|
|||
#controls > .right { | |||
float: right; | |||
#controls .button:not(:last-child) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should go to nextcloud/server#7478
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gallery uses a lot of similar styles but does not includes any of them (yes, we need to rebuild the entire app), therefor, there are a lot of multiples files/properties used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢
Buttons are always 44x44 on nextcloud! :) |
@skjnldsv be careful with 44x44 - it means we also need to make |
Well, I guess it won't be 44x44 then! I don't want to try and break everything! :O |
@skjnldsv ok, I've created a new issue for that: nextcloud/server#7481 |
What do you mean by that? |
@skjnldsv look here - folder breadcrumb is 2px lower than the rest: |
@pixelipo And it's the opposite on the files app, the buttons are 2px lower... |
@skjnldsv that problem would be solved with proper button size and margins |
Very true, by design apps should never rely on components delivered in the server, which is annoying. |
I pushed a fix to this branch to properly work with nextcloud/server#7484 this is now good to be merged. 👍 |
Let's skip this for this PR. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke I'll make another PR in a second |
Signed-off-by: Marin Treselj <marin.treselj@forlagshuset.no>
css/styles.css
Outdated
@@ -20,16 +17,19 @@ body:after { | |||
transition: transform .1s ease-in; | |||
} | |||
|
|||
div.crumb.last a { | |||
cursor: default; | |||
/* Two ugly hacks to fix breadcrumbs in Gallery */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this go in the gallery then? :)
EDIT: wrong pr, we are in the gallery 🙈 😆
Signed-off-by: Marin Treselj <marin.treselj@forlagshuset.no>
@pixelipo you're awesome! Perfect here! |
Signed-off-by: Marin Treselj <marin.treselj@forlagshuset.no>
Sorry, I lied - I found out that my "ugly hack" was causing a bug when only "Home" is the only breadcrumb. I've fixed it now, with the downside (which cannot be fixed without total rewrite of Gallery breadcrumbs) is that in case ellipsis is the last breadcrumb, it doesn't have the expected margin-right. I guess we can live with that for now ;) |
Signed-off-by: Marin Treselj <marin.treselj@forlagshuset.no>
My last (no, really) commit fixes the hover inconsistency issue mentioned by @MariusBluem in the nextcloud/server#7374 |
Another bump here? |
@skjnldsv travis-ci is failing:
|
Unrelated. I still haven't found the time to trace the regression. Could have been broken by a change in the server. There is an issue opened about it. |
@MorrisJobke @rullzer A review here? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
13+ I think. We need to test on stable12. |
Even if this pull request worked on 12 (and I made a quick check and there seems to be some issues) due to #331 the slideshow icons are not visible on a black background on Nextcloud 12: |
Ok lets bump to 13 only then we have the stable branches anyways |
Fixes nextcloud/server#7374
Needs nextcloud/server#7478