-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set min supported node at 16 #56
Conversation
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Default is the wrong word. Min-supported is more fitting. Sorry, this is not up to debate here ^^" Nonetheless we can also discuss about raising min-NPM to 8 as well, removing support for 7. But I don't see the reasoning behind this as node16 ships both npm 7 and 8 Please read nextcloud/standards#5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so talking only about the node version, i'm fine with this. 😉
This comment was marked as off-topic.
This comment was marked as off-topic.
I am fine with raising the node version to 16. On a side note, i would also prefer no warnings when using a supported npm version 😉 |
Discussion in nextcloud/standards#7 |
nextcloud/standards#1
Node 16 ships npm 8 since 16.11.0.
I suggest we just leave npm to 7.0.0 as this is the minimum supported. Devs can still use npm 8 if they want :)
Everyone on board?
@max-nextcloud @vinicius73 @artonge @CarlSchwan @JuliaKirschenheuter @GretaD @jotoeri @raimund-schluessler @korelstar @marcoambrosini @eneiluj