-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cant upload files to public shares in a groupfolders with advanced permissions on #811
Comments
his has been tested on three different servers |
After one more test .. it might be nextcloud server 18.0.2 after all, i will try this on one more server |
Duplicate of #486 |
this is not a duplicate. for me it has worked on nc16 and nc17 and nc18 it
doesnt work on nc18.0.1 or 18.0.2
/Johan
…On March 23, 2020 09:51:16 Chris ***@***.***> wrote:
Duplicate of#486
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I have the same issue on NC 18.0.2 but not on 18.0.1 |
Hello I just investigated again, the version 6.0.3 of Group Folders is buggy and leads external guest to errors like unknown error: and this is the error `Symfony\Component\Routing\Exception\RouteNotFoundException: Unable to generate a URL for the named route "photos.page.index" as such route does not exist. Error | public | Error: Call to undefined method OCP\Files\Cache\CacheInsertEvent::setPath()/var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php - line 247:OCA\GroupFolders\CacheListener->onCacheEvent(OCP\Files\Ca ... {}, "OCP\Files\ ... t", Symfony\Comp ... {})/var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php - line 73:Symfony\Component\EventDispatcher\EventDispatcher->callListeners([ Closure {},Closure {}], "OCP\Files\ ... t", OCP\Files\Ca ... {})/var/www/nextcloud/lib/private/EventDispatcher/EventDispatcher.php - line 80:Symfony\Component\EventDispatcher\EventDispatcher->dispatch(OCP\Files\Ca ... {}, "OCP\Files\ ... t")/var/www/nextcloud/lib/private/EventDispatcher/SymfonyAdapter.php - line 63:OC\EventDispatcher\EventDispatcher->dispatch("OCP\Files\ ... t", OCP\Files\Ca ... {})/var/www/nextcloud/lib/private/Files/Cache/Cache.php - line 305:OC\EventDispatcher\SymfonyAdapter->dispatch("OCP\Files\ ... t", OCP\Files\Ca ... {})/var/www/nextcloud/lib/private/Files/Cache/Wrapper/CacheWrapper.php - line 130:OC\Files\Cache\Cache->insert("__groupfold ... f", { mimetype: ... "})/var/www/nextcloud/lib/private/Files/Cache/Wrapper/CacheJail.php - line 123:OC\Files\Cache\Wrapper\CacheWrapper->insert("__groupfold ... f", { mimetype: ... "})/var/www/nextcloud/lib/private/Files/Cache/Wrapper/CacheWrapper.php - line 130:OC\Files\Cache\Wrapper\CacheJail->insert("*** sensiti ... ", { mimetype: ... "})/var/www/nextcloud/apps/groupfolders/lib/Mount/RootEntryCache.php - line 57:OC\Files\Cache\Wrapper\CacheWrapper->insert("** sensiti ... ", { mimetype: ... "})/var/www/nextcloud/lib/private/Files/Cache/Wrapper/CacheWrapper.php - line 130:OCA\GroupFolders\Mount\RootEntryCache->insert("** sensiti ... ", { mimetype: ... "})/var/www/nextcloud/lib/private/Files/Cache/Wrapper/CacheWrapper.php - line 130:OC\Files\Cache\Wrapper\CacheWrapper->insert("** sensiti ... ", { mimetype: ... "})/var/www/nextcloud/lib/private/Files/Cache/Wrapper/CacheWrapper.php - line 116:OC\Files\Cache\Wrapper\CacheWrapper->insert("** sensiti ... ", { mimetype: ... "})/var/www/nextcloud/lib/private/Files/Cache/Scanner.php - line 293:OC\Files\Cache\Wrapper\CacheWrapper->put("** sensiti ... ", { mimetype: ... "})/var/www/nextcloud/lib/private/Files/Cache/Scanner.php - line 222:OC\Files\Cache\Scanner->addToCache("** sensiti ... ", { mimetype: ... "}, -1)/var/www/nextcloud/lib/private/Files/Cache/Scanner.php - line 337:OC\Files\Cache\Scanner->scanFile("** sensiti ... ", 3, 5554, false, false)/var/www/nextcloud/lib/private/Files/Cache/Updater.php - line 124:OC\Files\Cache\Scanner->scan("** sensiti ... ", false, 3, false)/var/www/nextcloud/apps/dav/lib/Connector/Sabre/File.php - line 291:OC\Files\Cache\Updater->update("** sensiti ... ")/var/www/nextcloud/apps/dav/lib/Connector/Sabre/Directory.php - line 156:OCA\DAV\Connector\Sabre\File->put(null)/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 1096:OCA\DAV\Connector\Sabre\Directory->createFile("** sensiti ... ", null)/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php - line 525:Sabre\DAV\Server->createFile("** sensiti ... *", null, null)<>Sabre\DAV\CorePlugin->httpPut(Sabre\HTTP\R ... "}, Sabre\HTTP\Response {})/var/www/nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php - line 105:call_user_func_array([ Sabre\DAV\ ... "], [ Sabre\HTTP ... }])/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 479:Sabre\Event\EventEmitter->emit("method:PUT", [ Sabre\HTTP ... }])/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 254:Sabre\DAV\Server->invokeMethod(Sabre\HTTP\R ... "}, Sabre\HTTP\Response {})/var/www/nextcloud/apps/dav/appinfo/v1/publicwebdav.php - line 109:Sabre\DAV\Server->exec()/var/www/nextcloud/public.php - line 81:require_once("/var/www/ne ... p")` |
@mesiah1970-haydar 6.0.3 works for me on several servers except upload on public links. |
Yeah the upload on public links is kind of buggy, I just replaced the version 6.0.3 to 6.0.1 and works like a charm. So the point is to update the NC from 18.0.1 to 18.0.2 but not update the buggy GF Apps. However the GF updates automatically to 6.0.3 while updatting NC to 18.0.2, but you can only downgrade this app again to 6.01 |
And here are some further error, when I try to delte a file as an extarnal from external share. This spits also an unknown error: I'm using NC 18.0.3 with GF 6.0.3 Symfony\Component\Routing\Exception\RouteNotFoundException: Unable to generate a URL for the named route “photos.page.index” as such route does not exist. /var/www/nextcloud/lib/private/Route/Router.php - line 339:Symfony\Component\Routing\Generator\UrlGenerator->generate(“photos.page.index”, [], 1) /var/www/nextcloud/lib/private/URLGenerator.php - line 82:OC\Route\Router->generate(“photos.page.index”, []) /var/www/nextcloud/lib/private/NavigationManager.php - line 293:OC\URLGenerator->linkToRoute(“photos.page.index”) /var/www/nextcloud/lib/private/NavigationManager.php - line 114:OC\NavigationManager->init() /var/www/nextcloud/apps/theming/lib/ThemingDefaults.php - line 182:OC\NavigationManager->getAll(“guest”) /var/www/nextcloud/lib/private/legacy/defaults.php - line 263:OCA\Theming\ThemingDefaults->getShortFooter() /var/www/nextcloud/lib/public/Defaults.php - line 169:OC_Defaults->getLongFooter() /var/www/nextcloud/core/templates/layout.guest.php - line 55:OCP\Defaults->getLongFooter() /var/www/nextcloud/lib/private/Template/Base.php - line 179:include("/var/www/ne … p") /var/www/nextcloud/lib/private/Template/Base.php - line 151:OC\Template\Base->load("/var/www/ne … p", null) /var/www/nextcloud/lib/private/legacy/template.php - line 181:OC\Template\Base->fetchPage(null) /var/www/nextcloud/lib/private/legacy/template.php - line 212:OC_Template->fetchPage(null) /var/www/nextcloud/lib/private/Template/Base.php - line 132:OC_Template->fetchPage() /var/www/nextcloud/lib/private/legacy/template.php - line 333:OC\Template\Base->printPage() /var/www/nextcloud/public.php - line 94:OC_Template::printExceptionErrorPage(Error {}, 500) März 27, 2020 08:08:30 /var/www/nextcloud/apps/activity/lib/FilesHooks.php - line 638:OC\Files\View->getOwner("/Kundenname … f") /var/www/nextcloud/apps/activity/lib/FilesHooks.php - line 190:OCA\Activity\FilesHooks->getSourcePathAndOwner("/Kundenname … f") /var/www/nextcloud/apps/activity/lib/FilesHooks.php - line 165:OCA\Activity\FilesHooks->addNotificationsForFileAction("/Kundenname … f", “file_deleted”, “deleted_self”, “deleted_by”) /var/www/nextcloud/apps/activity/lib/FilesHooksStatic.php - line 63:OCA\Activity\FilesHooks->fileDelete("/Kundenname … f") /var/www/nextcloud/lib/private/legacy/hook.php - line 111:OCA\Activity\FilesHooksStatic::fileDelete({ run: true, … "}) /var/www/nextcloud/lib/private/Files/View.php - line 1275:OC_Hook::emit(“OC_Filesystem”, “delete”, { run: true, … "}) /var/www/nextcloud/lib/private/Files/View.php - line 1145:OC\Files\View->runHooks([ “delete”], “/Kundenname … f”) /var/www/nextcloud/lib/private/Files/View.php - line 716:OC\Files\View->basicOperation(“unlink”, “Lieferschein 2019-10589.pdf”, [ “delete”]) /var/www/nextcloud/apps/dav/lib/Connector/Sabre/File.php - line 448:OC\Files\View->unlink(“Lieferschein 2019-10589.pdf”) /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Tree.php - line 179:OCA\DAV\Connector\Sabre\File->delete() /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php - line 287:Sabre\DAV\Tree->delete(“Lieferschein 2019-10589.pdf”) <>Sabre\DAV\CorePlugin->httpDelete(Sabre\HTTP\R … "}, Sabre\HTTP\Response {}) /var/www/nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php - line 105:call_user_func_array([ Sabre\DAV\ … "], [ Sabre\HTTP … }]) /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 479:Sabre\Event\EventEmitter->emit(“method:DELETE”, [ Sabre\HTTP … }]) /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 254:Sabre\DAV\Server->invokeMethod(Sabre\HTTP\R … "}, Sabre\HTTP\Response {}) /var/www/nextcloud/apps/dav/appinfo/v1/publicwebdav.php - line 109:Sabre\DAV\Server->exec() /var/www/nextcloud/public.php - line 81:require_once("/var/www/ne … p") |
Same error messages as OP on deletion in public share. Web UI tells an error for upload/folder creation as well as deletion, however upload & creation works (file/folder still there after refresh), deletion does not (have to use logged in user to delete). |
Also for me, same errors as OP, same comment as @iexos, please resolve we're in production mode, thank you |
So with the latest 6.0.4 i can upload a file as a guest when i have upload and edit turned on. But file drop does not work still. Ping @juliushaertl @icewind1991 @rullzer this is a quite annoying bug. |
Hey small1, what do you mean with file drop? Do you mean file delete? Rgds Haydar |
@mesiah1970-haydar when you share a folder as a public link you can choose between read only, allow upload and editing and filedrop. |
Oh, thanks for the insight, so my question would be, if it is possible to delete files uploaded by an guest or host from a public share. I guess file drop I don't use Rgds Haydar |
@mesiah1970-haydar yes on upload and edit permission they should be able to delete a file. I can do that on My instances with groupfolders. But it might depend on the rights of the user creating the share. |
Ok thanks, I'll give a try and tell you the results. |
Hello all I can confirm now, that GF with Version 6.0.4 is working now:
Rgds Haydar |
File drop does not work. Still gives an error on my instances on debian 9 with php 7.2 and nginx |
an error log from your NC instance while you're dropping files would be fine to the developers for investigation. |
I confirm that GF with Version 6.0.4 is working correctly |
id did at the start of this bug request. But now when i check again i do have a different error. |
|
@critot Have you tested to create a public share with file drop rights and uploaded a file to it within a group folder? |
Aahh found one more variable. Advanced permissions is turned on to the nextcloud instances that it doesnt work on. |
So that's i!t As soon as i turn on ACL on the group folder i cant use file drop. |
Oh, I didn't try that with advanced permissions, never used it, since I never needed it |
I'm also seeing this issue: enabling advanced permissions on the group folder breaks uploading to a sub-folder shared as a File Drop. Public users cannot upload unless advanced permissions for the group folder is disabled. 3 errors are returned on my installation when the upload fails:
|
I came across the same issue. I'm using group folder 6.0.4 with Nextcloud 18.0.3. Thank you. |
@remogatto |
No. The issue still persists. |
Same issue. Same updated versions of NC and GF Also, to mention that I checked and the files actually DO GET UPLOADED but it still gives you the error Please Please Please check it asap. it's extremely confusing for users Thank you |
I also have exactly the same issue. I am using Nextclodu v18.0.3 and Grou folders version 6.0.5. |
Well Pilzinsel,
Well I've tested your scenario NC 18.03 + GF 6.0.5 and I could not generate such an error. File drop works well. BUT I've read, that with advanced permissions this error occurs. Could you please disable the advanced permissions on the GF and try to upload/drop again? Haydar |
Oh sorry. Yes, it use advanced permissions. |
I found out why the file is there only sometimes. It depends if the folder (or path) contains white spaces (%20). It yes, the file is missing and if no, the file is there. |
well, then this is a issue, which is certainly a bug. But this is mentioned in this issue few times. So the developers should have a look on it. Prior to your issue, we had an upload problem "unknown error" to public shares. This was resolved in 6.0.4. Anyway, some other issues now occurred. like the the advance file permission. Sorry in this case I'm out of options |
I am having the same issue. |
Same issue here, Occurred after upgraded NC to 19 (19.0.3 now) and groupfolders to 7.0.0, Is there any workaround for it? |
Is this bug still present? Any update? |
Yes the bug is still present, I've tested this morning on a Nextcloud 20.0.1 and I can't create a "file drop" share when the groupfolder as advanced permissions toggled on |
Same issue here. It works perfectly if I turn off the advance permissions. otherwise, uploads don't work via a public link. Thank you. |
Exactly same here. NC 20.0.5 |
I'll close as duplicate of #486 |
I am using nextcloud 18.0.1 and 18.0.2
This worked on 6.0.1 but does not work in 6.0.3
Error from nextcloud log:
{"reqId":"jC7AB57bmzB0aKbbRD9z","level":3,"time":"2020-03-20T06:32:46+00:00","remoteAddr":"41.86.35.64","user":"--","app":"public","method":"PUT","url":"/public.php/webdav/shield.png","message":{"Exception":"Error","Message":"Call to a member function getUID() on null","Code":0,"Trace":[{"file":"/var/www/nextcloud/apps/activity/lib/FilesHooks.php","line":638,"function":"getOwner","class":"OC\Files\View","type":"->","args":["/Bernhardsson/Test/Test//shield (2).png"]},{"file":"/var/www/nextcloud/apps/activity/lib/FilesHooks.php","line":190,"function":"getSourcePathAndOwner","class":"OCA\Activity\FilesHooks","type":"->","args":["/Bernhardsson/Test/Test//shield (2).png"]},{"file":"/var/www/nextcloud/apps/activity/lib/FilesHooks.php","line":148,"function":"addNotificationsForFileAction","class":"OCA\Activity\FilesHooks","type":"->","args":["/Bernhardsson/Test/Test//shield (2).png","file_created","","created_public"]},{"file":"/var/www/nextcloud/apps/activity/lib/FilesHooksStatic.php","line":47,"function":"fileCreate","class":"OCA\Activity\FilesHooks","type":"->","args":["/Bernhardsson/Test/Test//shield (2).png"]},{"file":"/var/www/nextcloud/lib/private/legacy/hook.php","line":111,"function":"fileCreate","class":"OCA\Activity\FilesHooksStatic","type":"::","args":[{"path":"/Bernhardsson/Test/Test//shield (2).png"}]},{"file":"/var/www/nextcloud/apps/dav/lib/Connector/Sabre/File.php","line":389,"function":"emit","class":"OC_Hook","type":"::","args":["OC_Filesystem","post_create",{"path":"/Bernhardsson/Test/Test//shield (2).png"}]},{"file":"/var/www/nextcloud/apps/dav/lib/Connector/Sabre/File.php","line":321,"function":"emitPostHooks","class":"OCA\DAV\Connector\Sabre\File","type":"->","args":[false]},{"file":"/var/www/nextcloud/apps/dav/lib/Connector/Sabre/Directory.php","line":156,"function":"put","class":"OCA\DAV\Connector\Sabre\File","type":"->","args":[null]},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":1096,"function":"createFile","class":"OCA\DAV\Connector\Sabre\Directory","type":"->","args":["shield (2).png",null]},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php","line":525,"function":"createFile","class":"Sabre\DAV\Server","type":"->","args":["shield (2).png",null,null]},{"function":"httpPut","class":"Sabre\DAV\CorePlugin","type":"->","args":[{"absoluteUrl":"https://cloud.ingenstans.net/public.php/webdav/shield.png","class":"Sabre\HTTP\Request"},{"class":"Sabre\HTTP\Response"}]},{"file":"/var/www/nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php","line":105,"function":"call_user_func_array","args":[[{"class":"Sabre\DAV\CorePlugin"},"httpPut"],[{"absoluteUrl":"https://cloud.ingenstans.net/public.php/webdav/shield.png","class":"Sabre\HTTP\Request"},{"class":"Sabre\HTTP\Response"}]]},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":479,"function":"emit","class":"Sabre\Event\EventEmitter","type":"->","args":["method:PUT",[{"absoluteUrl":"https://cloud.ingenstans.net/public.php/webdav/shield.png","class":"Sabre\HTTP\Request"},{"class":"Sabre\HTTP\Response"}]]},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":254,"function":"invokeMethod","class":"Sabre\DAV\Server","type":"->","args":[{"absoluteUrl":"https://cloud.ingenstans.net/public.php/webdav/shield.png","class":"Sabre\HTTP\Request"},{"class":"Sabre\HTTP\Response"}]},{"file":"/var/www/nextcloud/apps/dav/appinfo/v1/publicwebdav.php","line":109,"function":"exec","class":"Sabre\DAV\Server","type":"->","args":[]},{"file":"/var/www/nextcloud/public.php","line":81,"args":["/var/www/nextcloud/apps/dav/appinfo/v1/publicwebdav.php"],"function":"require_once"}],"File":"/var/www/nextcloud/lib/private/Files/View.php","Line":1690,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.116 Safari/537.36","version":"18.0.2.2"}
The text was updated successfully, but these errors were encountered: