Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Issue on shared Folder #486

Closed
dehsgr opened this issue Jun 18, 2019 · 46 comments
Closed

Upload Issue on shared Folder #486

dehsgr opened this issue Jun 18, 2019 · 46 comments
Labels
1. to develop Issues that are ready for development bug high high priority

Comments

@dehsgr
Copy link

dehsgr commented Jun 18, 2019

Assume the following conditions:

  • You created a group Folder
  • You created a nestes Folder
  • You shared the nested Folder via Link (upload only)
  • An User uploads a File via shared Link

User will receive an Error "Could not upload "The Name of File User uploaded"". The File is not shown to Users which have access to the Group Folder. After uploading another File, the first File is visible and uploaded correctly.

@FloMiLe
Copy link

FloMiLe commented Jul 21, 2019

I have a very similar experience. I tried the exact same thing, but the file that was attempted to be uploaded actually is not uploaded and never appears.

@emilianocapasso
Copy link

I have the same problem, the file won't upload.

the only way to make it works is to disable the "file drop (upload only)" in that way they can upload the files correctly

(NC 16.0.4 GF 4.1.4)

@nickian
Copy link

nickian commented Jan 6, 2020

Yes, file drop does not seem to work. When you try to upload a file it fails. Only the "allow upload and editing" version of a publicly shared folder seems to work. Can the file drop be fixed? It would be nice to have this feature available in group folders.

@bpcurse
Copy link

bpcurse commented Feb 13, 2020

I'm wondering if this issue nextcloud/server#17504 is somehow linked?

@deflektor-de
Copy link

I can confirm this issue. File is uploaded, but for the public uploader an error message is shown. So the user leaves frustrated, although the file was uploaded. Should definetly solved!

@mesiah1970-haydar
Copy link

Yes I have the same issue on 18.0.2, but not on 18.0.1. Following Issue occurred:

Issue: When a guest user uploads a file, he/she will get the error unknown error. The Upload is done to a shared Group Folder. The log shows then a following entry

Exception":“Symfony\Component\Routing\Exception\RouteNotFoundException”,“Message”:"Unable to generate a URL for the named route “photos.page.index” as such route does not exist.

The external user must do a refresh of his browser, and the he/she can see its file uploaded. This is not very practical. Als external guests have the problem, that they cannot delete their uploaded file.

@yonineitor
Copy link

Same problem

  • Nextcloud 18.02 (Only upload)
  • Ubuntu 18
  • Nginx

@iexos
Copy link

iexos commented Mar 30, 2020

Can confirm: NC 18.0.3, GF 6.0.3, Debian 10, nginx

@yonineitor
Copy link

Same problem

  • Nextcloud 18.02 (Only upload)
  • Ubuntu 18
  • Nginx

I must be edit
/apps/files_sharing/js/files_drop.js
$('#public-upload'). fail function by correct success

@mesiah1970-haydar
Copy link

mesiah1970-haydar commented Mar 31, 2020

Same problem

  • Nextcloud 18.02 (Only upload)
  • Ubuntu 18
  • Nginx

I must be edit
/apps/files_sharing/js/files_drop.js
$('#public-upload'). fail function by correct success

Could you tell us please, what and how the file must be edited

@yonineitor
Copy link

Try replace file NEXTCLOUD_PATH/apps/files_sharing/js/files_drop.js
by
https://github.com/yonineitor/nextcloud_file_sharing_group/blob/master/files_drop.js

Note: this is not fixed the error from server but force to show always a success saved

@mesiah1970-haydar
Copy link

mesiah1970-haydar commented Mar 31, 2020

Oh thanks for the update. But I guess it would be fighting the symptoms. I guess this file would be overwritten on the next update. Further I have the extra issue, that a deletion of a upload file into public, by an external shows an "unknown error":

see log:

Error public Error: Call to a member function getUID() on null

/var/www/nextcloud/apps/activity/lib/FilesHooks.php - line 638:OC\Files\View->getOwner("/Kundenname … f")

/var/www/nextcloud/apps/activity/lib/FilesHooks.php - line 190:OCA\Activity\FilesHooks->getSourcePathAndOwner("/Kundenname … f")

/var/www/nextcloud/apps/activity/lib/FilesHooks.php - line 165:OCA\Activity\FilesHooks->addNotificationsForFileAction("/Kundenname … f", “file_deleted”, “deleted_self”, “deleted_by”)

/var/www/nextcloud/apps/activity/lib/FilesHooksStatic.php - line 63:OCA\Activity\FilesHooks->fileDelete("/Kundenname … f")

/var/www/nextcloud/lib/private/legacy/hook.php - line 111:OCA\Activity\FilesHooksStatic::fileDelete({ run: true, … "})

/var/www/nextcloud/lib/private/Files/View.php - line 1275:OC_Hook::emit(“OC_Filesystem”, “delete”, { run: true, … "})

/var/www/nextcloud/lib/private/Files/View.php - line 1145:OC\Files\View->runHooks([ “delete”], “/Kundenname … f”)

/var/www/nextcloud/lib/private/Files/View.php - line 716:OC\Files\View->basicOperation(“unlink”, “Lieferschein 2019-10589.pdf”, [ “delete”])

/var/www/nextcloud/apps/dav/lib/Connector/Sabre/File.php - line 448:OC\Files\View->unlink(“Lieferschein 2019-10589.pdf”)

/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Tree.php - line 179:OCA\DAV\Connector\Sabre\File->delete()

/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php - line 287:Sabre\DAV\Tree->delete(“Lieferschein 2019-10589.pdf”)

<>Sabre\DAV\CorePlugin->httpDelete(Sabre\HTTP\R … "}, Sabre\HTTP\Response {})

/var/www/nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php - line 105:call_user_func_array([ Sabre\DAV\ … "], [ Sabre\HTTP … }])

/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 479:Sabre\Event\EventEmitter->emit(“method:DELETE”, [ Sabre\HTTP … }])

/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 254:Sabre\DAV\Server->invokeMethod(Sabre\HTTP\R … "}, Sabre\HTTP\Response {})

/var/www/nextcloud/apps/dav/appinfo/v1/publicwebdav.php - line 109:Sabre\DAV\Server->exec()

/var/www/nextcloud/public.php - line 81:require_once("/var/www/ne … p")

@critot
Copy link

critot commented Apr 1, 2020

Also here, same problem
NC 18.0.3, GF 6.0.3, Ubuntu18, nginx

After removed Activity App I've resolved the continuous error 'unknown error' (the upload was successful but the error was displayed), but it still remain impossible remove files and folders under a group folder for externals that have the shared link.
We have upgraded from NC17, where GF worked well, now it's a big problem, we're in production mode and we need GF without bugs and that works with Activity App enabled.
Thank you.

@gabrielklein
Copy link

Critical issue for me too :( 18.0.3

Get file property (profind), delete and upload don't work.
Disabling the "activity" app seams to improve some things... but still buggy.

@mesiah1970-haydar
Copy link

Hello dear developers of group folder.

could you give us some update on this? This issue seems to effect some people more and it is kind of nasty.

Rgds

Haydar

@mesiah1970-haydar
Copy link

Hello all

I can confirm now, that GF with Version 6.0.4 is working now:

Upload to public share is without an error
deletion of an file in the public share is without an error
File drop is on my installation of Nextcloud (no docker, just VM) is without an error
Rgds

Haydar

@gabrielklein
Copy link

On my side, everything is working perfectly with 6.0.4.
I've enabled the Activity app too.

I can upload, delete, profind, ... everything is great.

Great job!

@tsalex
Copy link

tsalex commented Apr 7, 2020

After updating to 6.0.4, I was still unable to successfully upload to a public file drop in a nested folder until I disabled advanced permissions for the parent group folder. Looks like there is an issue with advanced permissions?

Hope this is useful to you @critot -- I am also using the file drop feature in a production environment.

@mesiah1970-haydar
Copy link

Hello all, hello tsalex
@tsalex
unfortunately I cannot confirm your issue. I've enabled the advanced permissions on the Parent folder. I've created a Folder in the parent folder. People could upload, download, delete on the public share now

Rgds

Haydar

@critot
Copy link

critot commented Apr 8, 2020

I confirm that GF with Version 6.0.4 is working correctly
NC 18.0.3, GF 6.0.4, Ubuntu18, nginx
thank you!

@tsalex
Copy link

tsalex commented Apr 8, 2020

@mesiah1970-haydar Thanks for the reply! Can confirm that with advanced permissions enabled for the group folder, sharing a subfolder with the allow upload and editing option does work.

However, sharing with the File drop (upload only) option does not allow a user to upload -- it still throws an error.

I just noticed #811 -- I'll comment and post full error log there to avoid unnecessary issue duplication

@critot
Copy link

critot commented Apr 10, 2020

@tsalex
I confirm that in my environment File Drop work as expected, also in subfolders.

@kaspernowak
Copy link

@critot
Do you have advanced permissions enabled in your environment?

@critot
Copy link

critot commented Apr 24, 2020

@bananabreath
damn it!
AP checked and with admin group assigned, but I discover now that sharing with File Drop does not allow a user to upload (with modification allowed)!

@kaspernowak
Copy link

kaspernowak commented Apr 24, 2020

@critot
Damnit, I hope this will be solved in the next version..

@patricksebastien
Copy link

Nextcloud: 19.0.1
Groupfolder: 7.0.0
I am having this issue too. With advanced permission in place it's not possible to use the "File drop (Upload only)". A pop-up with Could not upload ...

Log is showing:

webdav
Error: Call to a member function getType() on bool
/pathto/nextcloud/app/3rdparty/sabre/event/lib/WildcardEmitterTrait.php - line 89:
OCA\DAV\Connector\Sabre\ServerFactory->OCA\DAV\Connector\Sabre\{closure}("*** sensiti ... *")
/pathto/nextcloud/app/3rdparty/sabre/dav/lib/DAV/Server.php - line 458:
Sabre\DAV\Server->emit()
/pathto/nextcloud/app/3rdparty/sabre/dav/lib/DAV/Server.php - line 251:
Sabre\DAV\Server->invokeMethod()
/pathto/nextcloud/app/3rdparty/sabre/dav/lib/DAV/Server.php - line 319:
Sabre\DAV\Server->start()
/pathto/nextcloud/app/apps/dav/appinfo/v1/publicwebdav.php - line 112:
Sabre\DAV\Server->exec()
/pathto/nextcloud/app/public.php - line 81:
require_once("/pathto/ne ... p")

@zaku903
Copy link

zaku903 commented Sep 17, 2020

Same issue here, Occurred after upgraded NC to 19 (19.0.3 now) and groupfolders to 7.0.0,

Is there any workaround for it?

@blooodorange
Copy link

+1 same issue here!

upload to "file drop (upload only)" is successful but user notification/pop-up indicates "could not upload "

nc: 20.0.0
gf: 8.0.0

Any news on this?

@Swalain
Copy link

Swalain commented Oct 17, 2020

Same problem here!

here some informations about the system running my nextcloud :
Operating system: Linux 3.16.0-6-amd64 #1 SMP Debian 3.16.57-2 (2018-07-14) x86_64
Webserver: Apache (fpm-fcgi)
Database: mysql 10.0.38
PHP version: 7.2.32
Nextcloud version: 20.0.0 - 20.0.0.9

steps to problem :
1- create folder
2- share link > create a "file drop (upload only)"
3- create new private tab in browser, paste the URL
4- Drop a file (or browse) -> Error top right : "Could not upload ".....""
note: file is actually uploaded in non-groupfolders folder

Disabling Activity does seem to solve the issue, but I need the email notification system and Activities tab to be up and running...

any updates or possible fix ? thanks!

@citrixguyblog
Copy link

I am having the same issue.
After disabling "Activity" the error on the top right side is gone.

Nextcloud version: 20.0.
Operating system and version: Debian 10.6
Apache or nginx version: Apache/2.4.38
PHP version: PHP 7.3.19-1

@biva
Copy link

biva commented Nov 10, 2020

Hello, we're wondering to use groupfolders in production, and I'm afraid of this issue: is this bug still present? Any update?

@iLims
Copy link

iLims commented Feb 2, 2021

I am having the same issue.

Nextcloud version: 20.0.6
Operating system and version: 5.8.0
PHP version: 7.4.14
GF version: 8.2.0

Disabling Activity doesn't solve the issue.

Log is showing:

webdav
Error: Call to a member function getType() on bool
/pathto/nextcloud/app/3rdparty/sabre/event/lib/WildcardEmitterTrait.php - line 89:
OCA\DAV\Connector\Sabre\ServerFactory->OCA\DAV\Connector\Sabre\{closure}("*** sensiti ... *")
/pathto/nextcloud/app/3rdparty/sabre/dav/lib/DAV/Server.php - line 458:
Sabre\DAV\Server->emit()
/pathto/nextcloud/app/3rdparty/sabre/dav/lib/DAV/Server.php - line 251:
Sabre\DAV\Server->invokeMethod()
/pathto/nextcloud/app/3rdparty/sabre/dav/lib/DAV/Server.php - line 319:
Sabre\DAV\Server->start()
/pathto/nextcloud/app/apps/dav/appinfo/v1/publicwebdav.php - line 112:
Sabre\DAV\Server->exec()
/pathto/nextcloud/app/public.php - line 81:
require_once("/pathto/ne ... p")

@pierreozoux pierreozoux added 0. Needs triage Issues that need to be triaged 1. to develop Issues that are ready for development bug high high priority and removed 0. Needs triage Issues that need to be triaged labels Mar 14, 2021
@kaspernowak
Copy link

kaspernowak commented Mar 17, 2021 via email

@devz3r0
Copy link

devz3r0 commented Mar 17, 2021

But we need the extended permission enabled in our organizational structure.

On Tue, 16 Mar 2021 at 13:43, devz3r0 @.***> wrote: if you disable the extended permissions in the group folder admin view, it should work. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#486 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDOPIVNQWZIJLVZVAKUWELTD5HANANCNFSM4HY6FAHQ .

Yes, but perhaps that hint helps the guy who can fix that, get to a solution quicker.

It fits to the error message with "bool" as the using extra permissions changes stuff from a plain off/on to an user dependent one.

@fschrempf
Copy link
Contributor

I tried to reproduce this on a clean NC 21.0..0 and groupfolders 9.0.0 and it seems like this issue does not happen there. Can anyone confirm?

@jngrb
Copy link
Contributor

jngrb commented Mar 31, 2021

Yes, I can confirm that is is working now. In the collaboration platform for "Ingenieure ohne Grenzen e.V." that I maintain with some friends, we can now also use public links directly into subfolders of a large ACL-managed groupfolders - after we have upgraded to NC 21.0.0 / groupfolders 9.0.0.

Great! We no longer have to use the fallback solution that used subgroup-specific "Input" groupfolders without ACLs.

Any guess which was the actual fix? I am very sure that it didn't work with NC 20 and groupfolders 8.

@fschrempf
Copy link
Contributor

Yes, I can confirm that is is working now.

Thanks a lot for your feedback!

Any guess which was the actual fix?

Unfortunately no. I'm not familiar with the codebase and the recent changes, so I can't tell at the moment. If we can find out we should consider a backport for the stable branches.

@fschrempf
Copy link
Contributor

Any guess which was the actual fix? I am very sure that it didn't work with NC 20 and groupfolders 8.

This change looks like it fixed the issue: #1224. But it was backported to NC 20 and 19, so it should be fixed there too now.

@patricksebastien
Copy link

It is not, tested with 20.0.8 and groupfolder 8.2.0.

@fschrempf
Copy link
Contributor

It is not, tested with 20.0.8 and groupfolder 8.2.0.

Thanks for testing. It looks like the last release for NC 20 was back in December (v8.2.0) and so recent fixes are not available there.
@juliushaertl Do you plan to push out new releases for NC 19 and NC 20, so users will get the upstream fixes?

@madoneee
Copy link

Hi !
Same problem on NC 21.0.1 et GF 9.0.0

@fschrempf fschrempf reopened this Apr 16, 2021
@madoneee
Copy link

Hi !
Same problem on NC 21.0.1 et GF 9.0.0

Installed app "File access control " and it works... So thank you for your attention ! :D

@fschrempf
Copy link
Contributor

Installed app "File access control " and it works... So thank you for your attention ! :D

I don't see how the "FIle access control" app could be related to this issue in groupfolders. Are you sure it works and it didn't work before? Did you do any other things that might have "fixed" it?

@patricksebastien
Copy link

Installing "File access control" didn't help. NC: 20.0.9 & groupfolder 8.2.0.

@Pilzinsel64
Copy link

Pilzinsel64 commented Apr 22, 2021

As one person who had and reported this bug I tested it again a few minutes ago...

I can confirm, it works now: NC21.0.1 + PHP8 + GF9.0.0
And it doesn't matter for me, if the app "File Access Control" is enabled or disabled. It works with and without.

Thank you very much!

@juliushaertl
Copy link
Member

Was fixed with #1224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Issues that are ready for development bug high high priority
Projects
None yet
Development

No branches or pull requests