Fix file drop shared folders #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ACL is enabled the READ permission is required to get any other permission on the group folder (or its contents). However, the ACLCacheWrapper verified not only that the READ permission was enabled for the folder/file, but also that it was being requested. Due to this it was not possible to publicly upload a file to a file drop shared folder inside a group folder, as in that case only SHARE + CREATE permissions are requested. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to stable20 |
|
/backport to stable19 |
|
/backport to stable18 |
ChristophWurst
approved these changes
Feb 25, 2021
This was referenced Feb 25, 2021
|
/backport to stable21 |
This was referenced Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #923
When ACL is enabled the READ permission is required to get any other permission on the group folder (or its contents). However, the
ACLCacheWrapperverified not only that the READ permission was enabled for the folder/file, but also that it was being requested. Due to this it was not possible to publicly upload a file to a file drop shared folder inside a group folder, as in that case only SHARE + CREATE permissions are requested.Reviewers: note that I know nothing about group folders, caches or storages, so please review carefully :-)
How to test
Result with this pull request
The file is uploaded.
Result without this pull request
The file fails to upload. The web console shows an internal error in the upload request (Nextcloud logs show
Call to a member function getType() on boolean, maybe a check forrootInfoshould be added there too to handle such errors more gracefully?).