Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] Fix file drop shared folders #1306

Merged
merged 1 commit into from
Feb 25, 2021
Merged

[stable20] Fix file drop shared folders #1306

merged 1 commit into from
Feb 25, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #1224

@danxuliu @juliusknorr
Fix file drop shared folders
9802f4f 
When ACL is enabled the READ permission is required to get any other
permission on the group folder (or its contents). However, the
ACLCacheWrapper verified not only that the READ permission was enabled
for the folder/file, but also that it was being requested. Due to this
it was not possible to publicly upload a file to a file drop shared
folder inside a group folder, as in that case only SHARE + CREATE
permissions are requested.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@juliusknorr juliusknorr merged commit 0b3c1db into stable20 Feb 25, 2021
@juliusknorr juliusknorr deleted the backport/1224/stable20 branch February 25, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @juliusknorr @danxuliu