Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encryption support #912

Closed
sbernhard opened this issue May 14, 2020 · 20 comments · Fixed by #2658
Closed

Add encryption support #912

sbernhard opened this issue May 14, 2020 · 20 comments · Fixed by #2658
Labels
0. Needs triage Issues that need to be triaged enhancement feature: encryption Items related to encryption features of NC integration

Comments

@sbernhard
Copy link

Currently, encryption isn't supported for group folders. Group folders are a highly used feature if you use nextcloud in groups - which is, a very common scenario.

To finish the story of encrypt all files and end-to-end encryption, it would really make sense to support encryption for group folders, too!

@ghost

This comment has been minimized.

@ryanerwin

This comment has been minimized.

@pcast43

This comment has been minimized.

@pierreozoux pierreozoux added the 0. Needs triage Issues that need to be triaged label Mar 14, 2021
@pierreozoux pierreozoux changed the title Feature Request: Use encryption for group folders Add encryption support Mar 14, 2021
@scoopex
Copy link

scoopex commented Mar 15, 2021

Yes, encryption for group folders should be a must have.
Users of the plugin should be warned when they try to use encrypted group folders when that is not supported.
Otherwise they consider the software to be be "unstable" - that's bad for this great project :-)

@jasond2020

This comment has been minimized.

@pierreozoux pierreozoux added the feature: encryption Items related to encryption features of NC label Apr 2, 2021
@c0d3m4tt3rz
Copy link

Is anything in particular stopping the development of this? Can we contribute anything? Is NC missing some core feature which makes this impossible?

@gitvime

This comment has been minimized.

@agentlibre
Copy link

agentlibre commented Jun 21, 2021

Could we have an official comment on this issue please ? Groupfolders is officially featured. Encryption 🔑 seems so critical for sovereign data hosting; it is beyond my comprehension that this issue has not been addressed at a higher priority level. 😮

Is there some alternative planning for group folders / sharing? What is there that we do not see here? 🧐

NB: not judging, just truly confused as a fervent supporter of NextCloud 🥺

@ghost

This comment has been minimized.

@juliusknorr
Copy link
Member

Nothing planned in that regard. I also question the actual use case of using server side encryption which was primarily designed for external storages. In the end the keys and secret (when using a master key) are stored on the same storage so anyone who has access to those can also decrypt the files.

@meznak
Copy link

meznak commented Jun 22, 2021

I also question the actual use case ... primarily designed for external storages.

Use case: I run NC in AWS, and would like to use S3 for storage. I have users who want to use group folders, but I don't trust the connection between my instance and S3. These features really shouldn't be mutually exclusive.

I understand this is a tricky problem to solve, but users have been asking for this for four years, and the need seems pretty clear cut to me.

@c0d3m4tt3rz
Copy link

I also question the actual use case of using server side encryption which was primarily designed for external storages

There are many use cases. External storage can be mounted locally. Protecting a single master key is a lot easier than an entire directory structure. And let's not forget the simple fact that NC supports locally encrypted storage, and that it's only the groupfolders feature that doesn't.

Some of the people in this thread have been trying to understand what the technical difficulties with this issue are. Some of us are willing to put in the effort to help get this off the ground. But this attitude of ignoring the problem for well over a year (and presumably longer) doesn't seem very constructive. We want to help, but we need a place to start.

@agentlibre
Copy link

agentlibre commented Jun 22, 2021

@juliushaertl Thank you for your prompt reply; much appreciated 🙌

Having the public & secret keys at the same location is not the only design possible though, is it? I'm no expert but I believe a program installed on another server could be used for authentication / master key validation.

@ghost

This comment has been minimized.

@patrickuhlmann
Copy link

I think if it is not supported at least it should not fail when moving files from a user share to a groupfolder. In my case the user share was encrypted and after moving the file to the group folder (using the web interface), the encrypted file was in the groupfolder but no keymaterial available anymore. The file was broken and I needed to recover from a backup.

At least encrypted files should be decrypted before moving to a group folder!

@kleener
Copy link

kleener commented Oct 9, 2022

What is the status here, since encryption can be activated in the latest release?
https://github.com/nextcloud/groupfolders/releases/tag/v12.0.2

@ghost
Copy link

ghost commented Dec 5, 2022

Still an issue on NC 25.0.1 with groupfolder enabled and encryption on

@kleener
Copy link

kleener commented Dec 5, 2022

in the following commit it looks like you still have to enable encryption for groupfolders:
2df8760

But I have not yet found anything about this in the documentary.

@x-merlin-x
Copy link

Any news on this one year later?

joshtrichards added a commit that referenced this issue Dec 5, 2023
Documents config value implemented in #2057 
Closes #912 

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member

Fixed in #2057

Off by default, but activated with the following command:

occ config:app:set groupfolders enable_encryption --value="true"

README doc addition in #2658 (pending).

come-nc pushed a commit that referenced this issue Jan 2, 2024
Documents config value implemented in #2057 
Closes #912 

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Issues that need to be triaged enhancement feature: encryption Items related to encryption features of NC integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

16 participants