Fix deletion failing even if there's an entry in the folder listing #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
juliusknorr
approved these changes
Mar 5, 2021
|
/backport to stable21 |
|
/backport to stable20 |
|
/backport to stable19 |
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you disable the app, delete a group and then re-enable the app, the group folders database and the group list will have diverged. That would be easy to fix via occ if it didn't check whether the group existed before deleting.
Since deleting a non-existent group doesn't break anything, I'd like to remove the check.
This is the same way it already works in the Frontend and OCS.
Please note: The diff here on github looks like I changed a lot but it's mostly just indentation.