Expire group folders trashbin

[CarlSchwan]

This is a continuation of #991 with the todo items done and rebased :)

[Ornanovitch]

🔥

[putt1ck]

Any chance this gets backported? Causes major issues on active installs (and kinda by definition these are the installations most likely to hold onto stable versions)

[CarlSchwan]

/backport to stable23

[CarlSchwan]

Hi @putt1ck and the others who added a 👍 to the comment ;)

I created a backport to 23. The release is next week and should also include the new admin delegation that I just backported as well.

[putt1ck]

Fast response! Any chance of a backport to 22? 21 is a bit much to ask obvs - though that's the version the largest installations we support are using...

[CarlSchwan]

It seems unlikely that we will backport this to 22. The MR doesn't apply cleanly and I'm not a fan of changing the behavior of the app in a minor release :/

[pgassmann]

@CarlSchwan @juliushaertl Now that Nextcloud 23 is released, can you create a new release of the groupfolders plugin that contains this long-awaited improvement?

[juliusknorr]

We will prepare a release when #1797 is merged

[pgassmann]

@juliushaertl Thank you. just got a notification for the update.

# ./occ groupfolders:expire
Removed 1402 expired trashbin items

[pgassmann]

on our up-to-date Nextcloud 23 I get an exception when running groupfolders:expire. See below. Is this a known issue?

@juliushaertl @CarlSchwan I see that there were potentially relevant commits directly after the latest release bc21eee
(We have versions an trash app enabled.)

How can I install the current master of the groupfolders app?

occ groupfolders:expire -vvv

In TrashBackend.php line 384:
                                       
  [Exception]                          
  Failed to remove item from trashbin  
                                       

Exception trace:
  at /var/www/html/custom_apps/groupfolders/lib/Trash/TrashBackend.php:384
 OCA\GroupFolders\Trash\TrashBackend->expire() at /var/www/html/custom_apps/groupfolders/lib/Command/ExpireGroupVersions.php:75
 OCA\GroupFolders\Command\ExpireGroupVersions->execute() at /var/www/html/3rdparty/symfony/console/Command/Command.php:255
 Symfony\Component\Console\Command\Command->run() at /var/www/html/core/Command/Base.php:168
 OC\Core\Command\Base->run() at /var/www/html/3rdparty/symfony/console/Application.php:1009
 Symfony\Component\Console\Application->doRunCommand() at /var/www/html/3rdparty/symfony/console/Application.php:273
 Symfony\Component\Console\Application->doRun() at /var/www/html/3rdparty/symfony/console/Application.php:149
 Symfony\Component\Console\Application->run() at /var/www/html/lib/private/Console/Application.php:211
 OC\Console\Application->run() at /var/www/html/console.php:99
 require_once() at /var/www/html/occ:11

groupfolders:expire [--output [OUTPUT]]