Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] allow enabling encryption for groupfolders #2103

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Sep 27, 2022

Manual backport of #2068 to stable23

Requires nextcloud/server#34102

Signed-off-by: Robin Appelman <robin@icewind.nl>
@PVince81 PVince81 added the 3. to review Items that need to be reviewed label Sep 27, 2022
@PVince81 PVince81 self-assigned this Sep 27, 2022
@PVince81
Copy link
Member Author

I've tested this locally, without encryption and with encryption enabled (need to set the flag with occ config:app:set), and I could see that both encrypted and non-encrypted files could be downloaded.

Newly uploaded files get encrypted.

And the keys are correctly in the system-wide storage.

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

lib/Mount/MountProvider.php Outdated Show resolved Hide resolved
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 requested a review from blizzz September 28, 2022 08:36
@blizzz blizzz added 4. to release Items that are ready for releasing and removed 3. to review Items that need to be reviewed labels Sep 28, 2022
@PVince81 PVince81 merged commit ec00cf3 into stable23 Sep 28, 2022
@PVince81 PVince81 deleted the groupfolder-encryption-23 branch September 28, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Items that are ready for releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants