fix(ACL): don't put inherited ACL permissions in the propPatch request payload

[Antreesy]

• Fix Inherited ACL permissions for groups in subfolder converted to local after adding new ACL rules #2659
• Including inherited permissions in client.propPatch request makes them local

⚠️ As #2637 is not solved yet, tested it on stable26 and stable27 only

Before	After
create ACL
remove ACL

[Antreesy]

/backport to stable27

[Antreesy]

/backport to stable26

[Antreesy]

/backport to stable28

[come-nc]

@Antreesy Hard to test this before UI is fixed. Ideally I would like a cypress test for this now that we have cypress setup, but it will need the UI to work as well I suppose.

[Antreesy]

it will need the UI to work as well I suppose.

Indeed, that would require sidebar view to test it. Now, with cypress we do everything with occ commands, one rule at the time, so impoossible to reproduce this error.

ATM web interface sends all rules together, which are handled by ACLPlugin propPatch method:

groupfolders/lib/DAV/ACLPlugin.php

Line 175 in 0026135

public function propPatch(string $path, PropPatch $propPatch): void {

As seen from there, it doesn't divide coming rules to inherited and local, consider them all as local, so we shouldn't pass inherited unless they haven't been changed.

[GretaD]

code looks good but i didnt test it

[mejo-]

Please disregard my last comment. For some reason I didn't run the code with your commit. Now that I fixed this, it works as expected 🎉