Add E2E tests for copying and moving shared groupfolders #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
force-pushed
the
add-e2e-tests-for-copying-and-moving-shared-groupfolders
branch
from
3d36454
to
e04cf6e
Compare
New filesUtils functions adjusted from cypress/e2e/files_sharing/filesSharingUtils.ts of Nextcloud server at commit 796237951145108172af27fa530a547f4e6b4967; note that "shareSettings" is not used, so there is no need to include the hack in "createShare" nor add the "updateShare" function. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
add-e2e-tests-for-copying-and-moving-shared-groupfolders
branch
from
e04cf6e
to
d89ff42
Compare
danxuliu
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds E2E tests for the issue fixed in nextcloud/server#47847 (some scenarios are fixed by that pull request, other scenarios work fine already but were added for completion).
[skip ci]was used for now until the fix is merged, as otherwise running one of the scenarios would recursively copy the data directory of the Nextcloud server and maybe cause issues in CI.