Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not expire labeled versions #3213

Merged
merged 2 commits into from
Sep 15, 2024
Merged

fix: Do not expire labeled versions #3213

merged 2 commits into from
Sep 15, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Sep 13, 2024 •
edited
Loading

Fix: #3095

@artonge artonge self-assigned this Sep 13, 2024
@artonge artonge added bug 3. to review Items that need to be reviewed php Items related to PHP updates and code issues feature: versions Items related to file versioning labels Sep 13, 2024
@artonge artonge added this to the Nextcloud 31 milestone Sep 13, 2024
@artonge
Copy link
Contributor Author

artonge commented Sep 13, 2024

/backport to stable30

@artonge
Copy link
Contributor Author

artonge commented Sep 13, 2024

/backport to stable29

@artonge artonge force-pushed the artonge/fix/do_not_expire_labeled_versions branch from d457e28 to 0eb424f Compare September 13, 2024 08:05
come-nc
come-nc approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay apart from missing stub.

lib/Versions/ExpireManager.php Show resolved Hide resolved
lib/Versions/ExpireManager.php Outdated Show resolved Hide resolved
@artonge
fix: Do not expire labeled versions
f41533d 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/do_not_expire_labeled_versions branch 2 times, most recently from 20ab61c to 99e95f2 Compare September 13, 2024 14:03
@artonge
=
37174bb 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/do_not_expire_labeled_versions branch from 99e95f2 to 37174bb Compare September 15, 2024 11:10
@artonge artonge merged commit 8be028a into master Sep 15, 2024
47 checks passed
@artonge artonge deleted the artonge/fix/do_not_expire_labeled_versions branch September 15, 2024 11:55
This was referenced Sep 15, 2024
Merged
Merged
@XueSheng-GIT XueSheng-GIT mentioned this pull request Oct 10, 2024
Closed
@XueSheng-GIT XueSheng-GIT mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

Assignees

@artonge artonge

Labels
3. to review Items that need to be reviewed bug feature: versions Items related to file versioning php Items related to PHP updates and code issues
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

data loss: named versions are lost from group folder after a while
2 participants
@artonge @come-nc