fix(psalm): Add all missing stubs #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
a team,
icewind1991,
yemkareems and
sorbaugh
and removed request for
a team
provokateurin
force-pushed
the
fix/psalm/missing-stubs
branch
2 times, most recently
from
39ef14d
to
e5b02a0
Compare
come-nc
requested changes
Sep 16, 2024
provokateurin
force-pushed
the
fix/psalm/missing-stubs
branch
from
e5b02a0
to
c88c16e
Compare
provokateurin
force-pushed
the
fix/psalm/missing-stubs
branch
3 times, most recently
from
e765022
to
9a4a569
Compare
|
Sorry for the mess 😓 |
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/psalm/missing-stubs
branch
from
9a4a569
to
70099f4
Compare
|
And one more to make reuse happy :/ |
|
the 3rdparty libs should probably be added as dev-dependency instead of adding them as stubs |
|
To get updates automatically? Or what would be the reason? |
|
If we add them as dev dependencies they don't necessary follow the same constraints as in 3rdparty, so I would rather have the stubs where we know that they exactly match the currently used versions. |
icewind1991
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated using https://github.com/provokateurin/php-stubs-updater with this command:
update-stubs.php tests/stubs ../../3rdparty/doctrine/dbal/ ../../3rdparty/icewind/streams/ ../../3rdparty/symfony/console/ ../../3rdparty/stecman/symfony-console-completion/ ../../lib/ ../../tests/lib/ ../../core/ ../dav/lib/ ../settings/lib/ ../circles/lib/ ../files/lib/ ../files_versions/lib/ ../files_trashbin/lib/ ../files_sharing/lib/Not sure if we should backport this, all the bugs it found do not lead to any runtime errors.