fix: Enforce strict types everywhere #3234
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, in CI it doesn't fail without the PR mentioned above. |
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/strict-types
branch
from
dc2ebad
to
07efcba
Compare
|
Code coverage in groupfolders is only around 30% which is way to little to turn this on with confidence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on nextcloud/server#48094 as View.php can't handle false for getOwner() everywhere.
All untouched files already had it enabled.