Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] High Performance File Backend #109

Open
Blackclaws opened this issue Apr 19, 2021 · 11 comments · May be fixed by #551 or #581
Open

[Feature] High Performance File Backend #109

Blackclaws opened this issue Apr 19, 2021 · 11 comments · May be fixed by #551 or #581
Labels
enhancement New feature or request Persistence Anything to do with external storage or persistence. This is also where we triage things like NFS.

Comments

@Blackclaws
Copy link

Are you planning to include the High Performance File Backend aka Client Push in the Helm chart or would you accept a pull request that adds this? This might be related to #106 as Nextcloud 21 is a base requirement for that.

@Blackclaws Blackclaws changed the title High Performance File Backend [Feature] High Performance File Backend Apr 19, 2021
@menardorama
Copy link
Contributor

Already have a working version but I can't find an elegant way to install and setup the app except using a one time job.
As of now it seems in my opinion that there is too much manual steps to cover...

@sbor23
Copy link

sbor23 commented May 25, 2021

Sorry for being off-topic.

If you find a way it would be great to expose the feature of specifying a range of apps to install along side. This would help a lot getting towards a true stateless setup.

@Blackclaws
Copy link
Author

Using a one time job is fine for setup things like this. A lot of other helm charts do that such as the gitlab chart

@menardorama
Copy link
Contributor

Yes you're right that seems possible

@chrisingenhaag
Copy link
Collaborator

I think it would be more nice to have a docker image of the notify_push serverside component instead of "installing" it within Pod start. I would prevent this if I can.

@Blackclaws
Copy link
Author

I guess having a separate docker image would also work, the concept of installing it into the server and simply mounting the same apps volume into notify push also works rather well however, that way you are also always in sync between the app and the service.

@jessebot
Copy link
Collaborator

I'm happy to review any pull request, but what exactly is the current plan here?

We are on Nextcloud 25 now, so this issue may be stale, but I'm happy to discuss regardless :)

@provokateurin
Copy link
Member

I found this issue because I was checking if notify_push is supported. @jessebot I think we should try making more Nextcloud components ready to use. I think that would include the HPBs for Files and Talk, notify_push and the Talk recording server (and maybe more). I don't know how hard each of these are, but it would be nice to support them.

@jessebot
Copy link
Collaborator

jessebot commented Dec 1, 2023

Sorry for the extreme delay. Sometime in June I accidentally cleared all my github notifications and I'm still wading through old issues and PRs trying to figure out what I missed 🤦

I think that would include the HPBs for Files and Talk, notify_push and the Talk recording server (and maybe more).

HPB is high performance backend, right? As in the backends listed in this blog post?

how do you feel about a nextcloud.objectStore section like mentioned in #477 (comment)?

Then we could have like:

nextcloud:
  objectStore:
    s3:
      enabled: true
    swift:
      enabled: false

@jessebot jessebot added the Persistence Anything to do with external storage or persistence. This is also where we triage things like NFS. label Dec 1, 2023
@Nils98Ar
Copy link

I found this issue because I was checking if notify_push is supported. @jessebot I think we should try making more Nextcloud components ready to use. I think that would include the HPBs for Files and Talk, notify_push and the Talk recording server (and maybe more). I don't know how hard each of these are, but it would be nice to support them.

Maybe some should be separate charts?

The templates from https://github.com/nextcloud/all-in-one/tree/main/nextcloud-aio-helm-chart/templates could probably be used as basis …

@AndreKoepke
Copy link

AndreKoepke commented Apr 2, 2024

This would be cool. It seems to me, that for the following things are required:

  • nginx should be able to upgrade to websocket connections https://github.com/nextcloud/notify_push?tab=readme-ov-file#nginx
  • No port must be exposed (nginx acts as proxy)
  • Server must be started (located at /var/www/html/custom_apps/notify_push/bin/x86_64/notify_push after installed as app)
  • OCC command to setup notifications must be started

Can we preconfigure that into the chart so that it will be the default?

AndreKoepke added a commit to AndreKoepke/helm that referenced this issue Apr 2, 2024
@AndreKoepke AndreKoepke linked a pull request Apr 2, 2024 that will close this issue
3 tasks
AndreKoepke added a commit to AndreKoepke/helm that referenced this issue Apr 2, 2024
Signed-off-by: e542445 <andre.koepke@sbb.ch>
AndreKoepke added a commit to AndreKoepke/helm that referenced this issue Apr 2, 2024
Signed-off-by: Andre Köpke <github@akop.online>
@wrenix wrenix linked a pull request Jun 9, 2024 that will close this issue
6 tasks
@jessebot jessebot added the enhancement New feature or request label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Persistence Anything to do with external storage or persistence. This is also where we triage things like NFS.
Projects
None yet
8 participants