Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previews with API error are not clickable #103

Open
ChristophWurst opened this issue May 3, 2024 · 3 comments
Open

Previews with API error are not clickable #103

ChristophWurst opened this issue May 3, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented May 3, 2024

image

^ I've noticed that when the link preview fails with the github integration there is no way to click your way to the link. You have to use the Copy link to clipboard action and open a new tab yourself.


Originally reported at nextcloud/text#5442 (comment)

@julien-nc
Copy link
Member

Hey, not sure it's about the widget content.
I mean, is it a requirement that the widget contains a <a> to the original link?
If not, Text should be changed so there is a way to visit/click the link whatever the widget content is.
IMO many widgets don't let you visit the original link. Image previews may not be clickable for example.
Wdyt?

@ChristophWurst
Copy link
Member Author

Fair points. We can continue in nextcloud/text#5442.

@provokateurin
Copy link
Member

I also have this issue and got the response in the Office chat that it is up to the widget provider to be clickable.
It is possible to still click the link inside the text but it is a lot less convenient and feels wrong to me.
In case of an error the "GitHub API error" part could just be made clickable.

@kyteinsky kyteinsky added the enhancement New feature or request label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants