Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link preview follow up #5442

Closed
10 of 11 tasks
juliushaertl opened this issue Mar 7, 2024 · 4 comments
Closed
10 of 11 tasks

Link preview follow up #5442

juliushaertl opened this issue Mar 7, 2024 · 4 comments
Assignees
@max-nextcloud
Labels
1. to develop bug Something isn't working

Comments

@juliushaertl
Copy link
Member

juliushaertl commented Mar 7, 2024 •
edited by max-nextcloud
Loading

Follow up from #5399
@juliushaertl juliushaertl added bug Something isn't working 1. to develop labels Mar 7, 2024
@juliushaertl juliushaertl mentioned this issue Mar 7, 2024
Merged
12 tasks
@max-nextcloud max-nextcloud mentioned this issue Mar 7, 2024
Merged
3 tasks
max-nextcloud added a commit that referenced this issue Mar 7, 2024
@max-nextcloud
fix(Preview): allow removing Preview with backspace
5edba62 
* Also only allow link marks inside the Preview.
* See #5442 for list of other follow up fixes for Previews

Signed-off-by: Max <max@nextcloud.com>
This was referenced Mar 7, 2024
Merged
Merged
max-nextcloud added a commit that referenced this issue Mar 7, 2024
@max-nextcloud
fix(Preview): allow removing Preview with backspace
db17b04 
* Also only allow link marks inside the Preview.
* See #5442 for list of other follow up fixes for Previews

Signed-off-by: Max <max@nextcloud.com>
max-nextcloud added a commit that referenced this issue Mar 13, 2024
@max-nextcloud
fix(Preview): allow removing Preview with backspace
18681f3 
* Also only allow link marks inside the Preview.
* See #5442 for list of other follow up fixes for Previews

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud mentioned this issue Mar 19, 2024
Merged
3 tasks
@ChristophWurst
Copy link
Member

image

^ I've noticed that when the link preview fails with the github integration there is no way to click your way to the link. You have to use the Copy link to clipboard action and open a new tab yourself.

I can file a separate issue if this isn't the right place to post this.

@juliushaertl
Copy link
Member Author

Yes, a separate ticket would be nice. Might actually be good to file it with the integration_github app as within text we do not have control over what the widget is doing.

max-nextcloud added a commit that referenced this issue Apr 23, 2024
@max-nextcloud
fix(linkBubble): only render when needed
d63c262 
Prevents 503 requests during tests.
See #5442.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud mentioned this issue Apr 23, 2024
Merged
2 tasks
@juliushaertl
Copy link
Member Author

@max-nextcloud Editing the link target from the modal might be tricky as the mark might span multiple nodes or also overlap with other marks. I'd say something we should split in a separate ticket as it might be larger work.

@ChristophWurst ChristophWurst mentioned this issue May 3, 2024
Open
@max-nextcloud
Copy link
Collaborator

Postponing the editing of link targets until the next iteration on links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-nextcloud max-nextcloud

Labels
1. to develop bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChristophWurst @juliushaertl @max-nextcloud