Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Preview: Add button to delete links in preview mode #5524

Closed
Tracked by #5442
mejo- opened this issue Mar 19, 2024 · 1 comment · Fixed by #5575
Closed
Tracked by #5442

Link Preview: Add button to delete links in preview mode #5524

mejo- opened this issue Mar 19, 2024 · 1 comment · Fixed by #5575
Assignees
Labels
29 feedback bug Something isn't working design Experience, interaction, interface, …
Milestone

Comments

@mejo-
Copy link
Member

mejo- commented Mar 19, 2024

Describe the bug
Currently there's no easily discoverable way to delete a link when it's displayed as preview. The Backspace key works, but it's not easily discoverable. You can also switch back to "Text only" and delete the link afterwards, but that's not very accessible either.

Expected behavior
We should expose a way to delete links that are displayed as previews somewhere in the API.

The best solution that comes to my mind is to add a "Delete" option to the three-dots-menu that allows to toggle between text/preview mode.

Another option would be an overlay "Delete" button like we have for images/attachments. But that would clutter the preview mode even more and is probably not a good idea.

@nextcloud/designers maybe you could give some input here?

Screenshots

Link preview with three-dot-menu
2024-03-19T09:43:18,042576387+01:00
@mejo- mejo- added bug Something isn't working design Experience, interaction, interface, … 29 feedback labels Mar 19, 2024
@mejo- mejo- added this to the Nextcloud 29 milestone Mar 19, 2024
@jancborchardt
Copy link
Member

The best solution that comes to my mind is to add a "Delete" option to the three-dots-menu that allows to toggle between text/preview mode.

@mejo- yep, totally agree with this. On the bottom there can be a separator and then an entry "Delete link" with a trash/delete icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29 feedback bug Something isn't working design Experience, interaction, interface, …
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants