Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link preview: toggle should be hidden if link preview is not possible #5522

Closed
Tracked by #5442
mejo- opened this issue Mar 18, 2024 · 0 comments · Fixed by #5544
Closed
Tracked by #5442

Link preview: toggle should be hidden if link preview is not possible #5522

mejo- opened this issue Mar 18, 2024 · 0 comments · Fixed by #5544
Assignees
@max-nextcloud
Labels
29 feedback bug Something isn't working
Milestone
Nextcloud 29

Comments

@mejo-
Copy link
Member

mejo- commented Mar 18, 2024

Describe the bug
When previewPossible is false, the toggle to change to preview should be hidden in my opinion.

At the moment, you can still toggle between text and preview in this case, but it has no user-visible effect.

To Reproduce
Steps to reproduce the behavior:

  1. Add a link that only contains a hash (e.g. #section)
  2. See the text/preview toggle left to this link
  3. Change to 'Display as preview'
  4. See nothing changing

Expected behavior
The toggle should be hidden in these cases.

Server details:

  • Nextcloud version: 29
@mejo- mejo- added bug Something isn't working 29 feedback labels Mar 18, 2024
@mejo- mejo- added this to the Nextcloud 29 milestone Mar 18, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Mar 18, 2024
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Mar 18, 2024
This was referenced Mar 19, 2024
Closed
Closed
@max-nextcloud max-nextcloud mentioned this issue Mar 21, 2024
Merged
3 tasks
@juliusknorr juliusknorr moved this from 📄 To do (~10 entries) to 👀 In review in 📝 Office team Mar 21, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-nextcloud max-nextcloud

Labels
29 feedback bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging a pull request may close this issue.

Fix/5522 no link preview toggle for anchor links nextcloud/text
2 participants
@mejo- @max-nextcloud