add config for the psalm to check unused variables and parameter

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nextcloud · Jun 26, 2024 · a460716 · a460716
1 parent c83e5fc
commit a460716
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 15 deletions.
diff --git a/lib/Controller/ConfigController.php b/lib/Controller/ConfigController.php
@@ -192,7 +192,7 @@ private function setIntegrationConfig(array $values): array {
 		];
 		// if values contains a key that is not in the allowedKeys array,
 		// return a response with status code 400 and an error message
-		foreach ($values as $key => $value) {
+		foreach (array_keys($values) as $key) {
 			if (!in_array($key, $allowedKeys)) {
 				throw new InvalidArgumentException('Invalid key');
 			}

diff --git a/lib/Controller/DirectUploadController.php b/lib/Controller/DirectUploadController.php
@@ -171,7 +171,6 @@ public function directUpload(string $token):DataResponse {
 				throw new NotFoundException('invalid token');
 			}
 			$tokenInfo = $this->directUploadService->getTokenInfo($token);
-			$fileId = null;
 			$directUploadFile = $this->request->getUploadedFile('file');
 			if (empty($directUploadFile)) {
 				throw new OpenprojectFileNotUploadedException(

diff --git a/lib/Service/OpenProjectAPIService.php b/lib/Service/OpenProjectAPIService.php
@@ -230,7 +230,6 @@ public function searchWorkPackage(
 		bool $onlyLinkableWorkPackages = true,
 		int $workPackageId = null
 	): array {
-		$resultsById = [];
 		$filters = [];
 
 		// search by description
@@ -567,7 +566,7 @@ public static function validateIntegrationSetupInformation(?array $values, bool
 				throw new InvalidArgumentException('invalid data');
 			}
 		} else {
-			foreach ($values as $key => $value) {
+			foreach (array_keys($values) as $key) {
 				if (!in_array($key, $opKeys)) {
 					throw new InvalidArgumentException('invalid key');
 				}
@@ -724,7 +723,7 @@ public function linkWorkPackageToFile(
 			'workpackageId',
 			'fileinfo'
 		];
-		foreach ($values as $key => $value) {
+		foreach (array_keys($values) as $key) {
 			if (!in_array($key, $allowedKeys)) {
 				throw new InvalidArgumentException('invalid key');
 			}

diff --git a/psalm.xml b/psalm.xml
@@ -7,6 +7,7 @@
 	xsi:schemaLocation="https://getpsalm.org/schema/config"
 	findUnusedBaselineEntry="false"
 	findUnusedCode="false"
+	findUnusedVariablesAndParams="true"
 	autoloader="bootstrap.php"
 >
 	<projectFiles>

diff --git a/tests/acceptance/features/bootstrap/FeatureContext.php b/tests/acceptance/features/bootstrap/FeatureContext.php
@@ -548,9 +548,9 @@ public function theDataOfTheOCSResponseShouldMatch(
 		PyStringNode $schemaString
 	): void {
 		$responseAsJson = json_decode($this->response->getBody()->getContents());
-		$responseAsJson = $responseAsJson->ocs->data;
+		$_responseAsJson = $responseAsJson->ocs->data;
 		JsonAssertions::assertJsonDocumentMatchesSchema(
-			$responseAsJson,
+			$_responseAsJson,
 			$this->getJSONSchema($schemaString)
 		);
 	}
@@ -564,9 +564,9 @@ public function theDataOfTheOCSResponseShouldMatch(
 	public function theDataOfTheResponseShouldMatch(
 		PyStringNode $schemaString
 	): void {
-		$responseAsJson = json_decode($this->response->getBody()->getContents());
+		$_responseAsJson = json_decode($this->response->getBody()->getContents());
 		JsonAssertions::assertJsonDocumentMatchesSchema(
-			$responseAsJson,
+			$_responseAsJson,
 			$this->getJSONSchema($schemaString)
 		);
 	}

diff --git a/tests/lib/Controller/ConfigControllerTest.php b/tests/lib/Controller/ConfigControllerTest.php
@@ -450,9 +450,7 @@ public function testOauthNoAccessTokenInResponse($oauthResponse, $expectedErrorM
 				['testUser', 'integration_openproject', 'oauth_connection_result', 'error'],
 				['testUser', 'integration_openproject', 'oauth_connection_error_message', $expectedErrorMessage],
 			);
-		/**
-		 * @var ConfigController
-		 */
+
 		$configController = new ConfigController(
 			'integration_openproject',
 			$this->createMock(IRequest::class),
@@ -837,7 +835,7 @@ public function checkForUsersCountBeforeTest($expectedCount = 1): IUserManager {
 		$actualCount = 1;
 		$userManager = \OC::$server->getUserManager();
 		$count = 0;
-		$function = function (IUser $user) use (&$count) {
+		$function = function () use (&$count) {
 			$count++;
 			return null;
 		};

diff --git a/tests/lib/Service/OpenProjectAPIServiceTest.php b/tests/lib/Service/OpenProjectAPIServiceTest.php
@@ -2804,10 +2804,9 @@ public function testMarkAllNotificationsOfANotExistingWorkPackageAsReadPact(): v
 			->with($consumerRequest)
 			->willRespondWith($providerResponse);
 
-
 		$service = $this->getOpenProjectAPIService();
 		$this->expectException(OpenprojectErrorException::class);
-		$result = $service->markAllNotificationsOfWorkPackageAsRead(
+		$service->markAllNotificationsOfWorkPackageAsRead(
 			789,
 			'testUser'
 		);