feat: Allow to show logs of all logging types by proxying messages #1041
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
==============================================
- Coverage 100.00% 27.78% -72.22%
- Complexity 0 188 +188
==============================================
Files 10 18 +8
Lines 168 565 +397
Branches 31 0 -31
==============================================
- Hits 168 157 -11
- Misses 0 408 +408
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
susnux
force-pushed
the
feat/allow-listing-all-logs
branch
7 times, most recently
from
463a66a
to
b52244f
Compare
susnux
force-pushed
the
feat/allow-listing-all-logs
branch
from
b52244f
to
5c13cc9
Compare
…non-file based loggers Also no longer provide the "enabled" setting as now all log types are supported Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Decided to rotate instead of truncate for future use with possible feature that also supports reading the rotated log file. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/allow-listing-all-logs
branch
from
5c13cc9
to
ea032e8
Compare
|
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
|
I like the idea 👍 |
log_typeto besyslog#979This creates an internal log file for all non file loggers, this enables showing all kind of logs.
The internal log file is then rotated by a background job, I think rotation makes more sense to keep the behavior similar to the file logger log file.
Maybe we can add a feature in the future to read also rotated logs (Nextcloud & internal log).
TODO