Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(format): export missing formatTime function #1339

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 13, 2024

Backport of #1338

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@backportbot backportbot bot requested a review from Antreesy August 13, 2024 15:00
@backportbot backportbot bot added this to the Nextcloud 29.0.5 milestone Aug 13, 2024
@szaimen szaimen marked this pull request as ready for review August 13, 2024 15:12
@szaimen
Copy link

szaimen commented Aug 13, 2024

/compile amend /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@joshtrichards joshtrichards merged commit d73ed10 into stable29 Aug 13, 2024
25 of 26 checks passed
@joshtrichards joshtrichards deleted the backport/1338/stable29 branch August 13, 2024 18:52
@szaimen
Copy link

szaimen commented Aug 13, 2024

@joshtrichards CI was red

@joshtrichards
Copy link
Member

joshtrichards commented Aug 13, 2024

Crap! In server I don't have override privs, but I do here so I didn't notice. Oops.

Fortunately it was just the block during freezes one.

I don't think it's necessary to revert, but will if someone feels strongly about it.

At least the merge matches the specified milestone. ;-)

@skjnldsv skjnldsv mentioned this pull request Aug 20, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants