Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail filters #10135

Merged
merged 3 commits into from
Oct 16, 2024
Merged

mail filters #10135

merged 3 commits into from
Oct 16, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 12, 2024 •
edited
Loading

Todo Hamza:

  • Use NcSelect with multiple objects for test value selection (wrapped, unlimited width)
  • Actions: Add label "Delete action"
  • Divider/Whitespace to group tests and actions
  • Delete filter => weird state
  • Save filter => success toast
  • Form validation => Make it a real form
  • Error state
  • MailFilterOperator: Don't modify prop
  • Remove operator true
  • Enable filter by default
  • Change modal title "Name inside modal " to "Update mail filter"
  • Check modal size
  • Input spacing/width

Todo Daniel:

  • Add tests
  • Tests with ooo script
  • Filter definitions (follow up)
  • To much newlines for the generate script
  • Support for quotes in values
  • Translation for operators
  • Help text

@ChristophWurst ChristophWurst marked this pull request as draft September 12, 2024 09:32
@kesselb kesselb changed the title Mail filters mail filters Sep 12, 2024
@hamza221 hamza221 mentioned this pull request Sep 12, 2024
Merged
hamza221
hamza221 reviewed Sep 16, 2024
View reviewed changes
src/components/MailFilters.vue Outdated
this.loading = false
}

await this.$store.dispatch('fetchActiveSieveScript', { accountId: this.account.id })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the store manually instead of querying backend on each update ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, do I need to return the new script as result for the update operation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of it in the other PR

@kesselb kesselb force-pushed the mail-filters branch 2 times, most recently from 37cad8d to 5bbace0 Compare September 18, 2024 15:19
@kesselb kesselb force-pushed the mail-filters branch 3 times, most recently from 112a1de to 259d411 Compare October 2, 2024 16:21
@kesselb kesselb force-pushed the mail-filters branch 7 times, most recently from 9085eca to 0981ed7 Compare October 11, 2024 15:08
@kesselb kesselb added this to the v4.1.0 milestone Oct 11, 2024
@kesselb kesselb marked this pull request as ready for review October 11, 2024 15:59
ChristophWurst
ChristophWurst approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍 :shipit:

src/components/mailFilter/DeleteModal.vue Outdated
- SPDX-License-Identifier: AGPL-3.0-or-later
-->
<template>
<NcDialog :name="t('mail','Delete mail filter {filterName}?', {filterName: filter.name})"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<NcDialog :name="t('mail','Delete mail filter {filterName}?', {filterName: filter.name})"
<NcDialog :name="t('mail', 'Delete mail filter {filterName}?', {filterName: filter.name})"

st3iny
st3iny approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! Tested and works.

Eslint is not yet happy though.

kesselb and others added 3 commits October 16, 2024 12:05
@kesselb
refactor: move imap flag encoding to helper
3906f27 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
feat: add sieve utils
9486987 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb @hamza221
feat: mail filters
d74c401 
Co-authored-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb merged commit 19b9286 into main Oct 16, 2024
35 checks passed
@kesselb kesselb deleted the mail-filters branch October 16, 2024 11:42
@kesselb kesselb mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza221 hamza221 hamza221 left review comments

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

@GVodyanov GVodyanov Awaiting requested review from GVodyanov

Assignees

@kesselb kesselb

@hamza221 hamza221

Labels
3. to review enhancement
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kesselb @ChristophWurst @st3iny @hamza221