-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings: reduce amount of sections #9879
Conversation
use the heading that fits semantically. we have to fix/adjust the font size instead. is the heading too small? |
Here's what it looks like when it's "correct" (an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Way easier to understand now. Agreed about the heading sizes, we should use the semantically correct heading tag. Some additional comments related to mostly wording:
- Wording changes:
- "Appearance and accessibility" as a heading may be misleading as it contains settings related to composing, searching, etc. We could just use the heading "General" (ref Gmail)
- "Auto tag text" --> "Mark as important"
- "Activate body search" --> "Search in body"
- "Privacy and Security" --> "Privacy and security" (no capital S)
- "Keyboard shortcuts" should be its own category as that's more accessible, it can be the last category
- "Mailto" as a separate item seems a bit strange, it can just go into the general settings now that it's not related to appearance
- Order of general settings:
- Layout
- Sorting,
- Search in body
- Reply text position
- Gravatar
- Mailto
We out keyboard shortcuts into Appearance and accessibility because server has it there too. |
@nimishavijay Done, what do you mean by "auto tag text" though? EDIT: now that Christoph explained, changed that too :) |
Automatically classify importance of new email |
I think it was closed by mistake |
Hey @nimishavijay does this look alright? |
@nimishavijay's suggestions are addressed. Let's get this in 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Grigory V <scratchx@gmx.com>
6d39309
to
1118fa0
Compare
Fix #9837
Account creation: account creation
Appearance and accessibility: layout, activate body search, gravatar settings, reply text position, sorting, keyboard shortcuts
Privacy and security: data collection consent, trusted senders, S/MIME, mailvelope
Assistance features: assistance features
Mailto: mailto
Also:
h6
tag to describe every setting (h6
because anything larger would be larger than the 'NcAppSettingsSection` title)