Photos on the map

[jancborchardt]

Using EXIF geolocation data, we could have pictures show up on the map when they have a location set. That could simply be sourced from the Files app (doesn’t really have much to do with the Gallery app).

cc @v1r0x @brantje for Maps and cc @oparoz @icewind1991 for photos and metadata.

[v1r0x]

I added exif extraction in one of the other branches (don't remember which one exacty).
So the code already exists, but should maybe moved to a separate PR. What do you think @jancborchardt ?

[jancborchardt]

@v1r0x sounds great! Maybe just find which was the branch and open a work-in-progress pull request so other people can check it out and maybe contribute. :)

[davidpeach]

I'd love to have a go at this issue. I'm looking to contribute and this looks like a good challenge. To start with.

[oparoz]

We're starting to have an EXIF issue.
Some parameters are fetched in the server, not sure if it's at upload time. I don't think it's documented yet and there is no API to retrieve the info.
There is also the mediametadata app which will eventually be finished and usable.
So we have 2 sources already and if each app starts parsing for EXIF data, then it's a hug waste of resources.

1st step would be to identify what is going on in the server side and whether this should be extended or dropped.

[jancborchardt]

@v1r0x @nextcloud/maps could you help @davidpeach to get started here? :)

[v1r0x]

The exif stuff has already been merged. This is very basic and only extracts the gps position. But I'm with @oparoz . Not sure if it is good to do an own exif extraction if this is already worked on.

[e-alfred]

There is now another app for Nextcloud that does exaclty this:

https://github.com/BatPio/PhotoMap

Maybe a cooperation would be useful?

[jancborchardt]

Yup, I recently saw this too. :)

@BatPio @v1r0x let's work on having this functionality directly in the rework of the Maps app! :)

[v1r0x]

Will have a look at it after the other 0.1 stuff. We should compare this one with the implementation of the old app regarding performance etc :)

[BatPio]

Duplicating functionalities is not good, but my app is almost ready and could be useful for users before this functionality will be implemented in nextcloud/map.

@jancborchardt @v1r0x I see that You started refactoring nextcloud/map. How long can it take? If it's matter of months, then I will release my app in market.

I can help You with this feature when refactoring will be finished :)

[jancborchardt]

@BatPio I’d really prefer if we can work together here. :) Otherwise we have 5 different Maps-related apps. Let’s join forces and build one really good Maps app together. @v1r0x @eneiluj

[v1r0x]

@BatPio the basic functionality (leaflet) is already there. I'm on vacation the next days, so you could have a look at the current code base and maybe add your code as PR without me modifying the code in the meantime ;)

[BatPio]

@jancborchardt @v1r0x First must be discussed what should extract exif data, and where they should be stored. I read in EXIF information for 13 that idea of implementing it in core server library was rejected. Maps app could extract geolocalizationa data, but what if other apps will need other metadatas (ex. photo taken date for grouping photos by months). I wonder if all metadatas should be stored in same table.

[jancborchardt]

@BatPio I reopened the EXIF issue in core :)

Nevertheless it seems best if first we do a working version directly inside the Maps app, cause right now we have it separate across core, Maps, and your specific app. :)

[BatPio]

@jancborchardt Ok, I have already written lat/long extraction command and files hooks for my app. I can reuse it in nextcloud/maps. I'll try to implement showing photos on map for nextcloud/maps :)

[jancborchardt]

@BatPio awesome stuff! :)

[BatPio]

@jancborchardt, @v1r0x I've finished moving code from my app. I also made some improvements. Do you want to review the changes before I make PR? https://github.com/BatPio/maps/tree/rework

[v1r0x]

I'd prefer a PR and discuss and review it then. Thanks for all the work :)

[v1r0x]

fixed in #21