Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Photos with zero Island #811

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Test Photos with zero Island #811

merged 1 commit into from
Aug 7, 2022

Conversation

tacruc
Copy link
Collaborator

@tacruc tacruc commented Aug 4, 2022

Zero Island photos should have location [null,null] and not [0.0,0.0] if invalidateZeroIsland is set to true.

@tacruc tacruc force-pushed the test/invalidateZeroIsland branch 3 times, most recently from 9b8736d to 04530f3 Compare August 4, 2022 13:39
@codecov-commenter
Copy link

Codecov Report

Merging #811 (04530f3) into master (c51b083) will decrease coverage by 1.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #811      +/-   ##
============================================
- Coverage     58.31%   57.02%   -1.30%     
- Complexity     1138     1153      +15     
============================================
  Files            42       47       +5     
  Lines          3481     3518      +37     
============================================
- Hits           2030     2006      -24     
- Misses         1451     1512      +61     
Flag Coverage Δ
unittests 57.02% <ø> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nextcloud/apps/maps/lib/Hooks/FileHooks.php 25.58% <0.00%> (-18.61%) ⬇️
nextcloud/apps/maps/lib/Service/TracksService.php 68.59% <0.00%> (-1.20%) ⬇️
.../apps/maps/lib/Controller/PublicPageController.php 66.07% <0.00%> (-0.60%) ⬇️
...tcloud/apps/maps/lib/Service/PhotofilesService.php 56.61% <0.00%> (-0.32%) ⬇️
nextcloud/apps/maps/lib/Service/DevicesService.php 73.76% <0.00%> (-0.20%) ⬇️
...xtcloud/apps/maps/lib/Service/FavoritesService.php 65.83% <0.00%> (-0.16%) ⬇️
...tcloud/apps/maps/lib/Controller/PageController.php 100.00% <0.00%> (ø)
...loud/apps/maps/lib/Controller/PhotosController.php 100.00% <0.00%> (ø)
...loud/apps/maps/lib/Controller/TracksController.php 86.44% <0.00%> (ø)
...oud/apps/maps/lib/Controller/DevicesController.php 95.91% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tacruc tacruc force-pushed the test/invalidateZeroIsland branch from 04530f3 to 0ba59b0 Compare August 4, 2022 13:54
Signed-off-by: Arne Hamann <git@arne.email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants