-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextcloud)!: Support server 29 and spreed 19 #1894
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
==========================================
- Coverage 29.31% 28.02% -1.30%
==========================================
Files 245 245
Lines 76519 81423 +4904
==========================================
+ Hits 22430 22817 +387
- Misses 54089 58606 +4517
*This pull request uses carry forward flags. Click here to find out more.
|
f649088
to
4c13292
Compare
Everything merged upstream, this PR is ready :) |
So far LGTM |
4c13292
to
fb28860
Compare
@Leptopoda please review the maxItems fix. I think there is something fundamentally wrong about checks for types in someOfs because they don't get generated anywhere, but that was already the case before and is not in scope of this fix. |
fb28860
to
007a96f
Compare
packages/dynamite/dynamite_runtime/lib/src/utils/array_checker.dart
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite_runtime/lib/src/utils/array_checker.dart
Outdated
Show resolved
Hide resolved
Can you show me where you'd expect one but they are not generated? |
For example https://github.com/nextcloud/neon/blob/007a96fa4334433ac35e00fc0d794fd015184f3b/packages/nextcloud/lib/src/api/spreed.openapi.dart#L16365C9-L16365C25 should have the check but I don't see it anywhere. |
I see. The only validation it uses is through the use of |
Yeah, no point in spending time on fixing this right now. |
007a96f
to
ebed1ff
Compare
@Leptopoda can you review again? |
looks good for now. |
ebed1ff
to
adce63d
Compare
adce63d
to
291f2bf
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
291f2bf
to
9a18a95
Compare
9a18a95
to
1f39624
Compare
Depends on nextcloud/server#44732Once the server releases are done and the docker images are available we can also test against those and get this merged.This is not the final version (I hope for nextcloud/spreed#12041 to land), but everything is working already when testing against the old versions.