Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dynamite)!: allow arbitrary objects in fromJson and toJson #2008

Closed

Conversation

Leptopoda
Copy link
Member

@Leptopoda Leptopoda commented May 4, 2024

needed for #1508 as a serialized someof can be a primitive type

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@provokateurin
Copy link
Member

On a second thought: Wouldn't it make sense to only return Object where necessary and keep Map<String, dynamic> everywhere else?

@Leptopoda
Copy link
Member Author

You are right.
Cloasing as the changes have to land with the bigger PR

@Leptopoda Leptopoda closed this May 4, 2024
@Leptopoda Leptopoda deleted the refactor/dynamite/allow_object_deserialization branch May 4, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants