fix: Mark as read on Scroll #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
approved these changes
Oct 17, 2024
Signed-off-by: Wolfgang <github@linux-dude.de>
Grotax
force-pushed
the
mark_read_onscroll
branch
from
31bd2db to
7e85ec5
Compare
Grotax
added a commit
that referenced
this pull request
Oct 23, 2024
Changed - Feed ordering will now be used for sorting items (#2678) Fixed - restore old scroll behavior to scroll after articles needed for mark scroll on read (#2817) - 25.0.0-alpha2: Feed folder bar menu always opens collapsed (#2508) - fix: hide folder/feeds with no unread items when `showAll` is disabled (#2503) - Items keep popping up in Folder, All or Unread view (#2833) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Oct 23, 2024
Changed - Feed ordering will now be used for sorting items (#2678) Fixed - restore old scroll behavior to scroll after articles needed for mark scroll on read (#2817) - 25.0.0-alpha2: Feed folder bar menu always opens collapsed (#2508) - fix: hide folder/feeds with no unread items when `showAll` is disabled (#2503) - Items keep popping up in Folder, All or Unread view (#2833) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The last items at the end are not marked read, because they do not scrolled out. This will be another task to scroll the last items out of the view as in news 24.
Checklist