Display modes and screen reader mode #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low combining modes Signed-off-by: Wolfgang <github@linux-dude.de>
This mode uses the no-spilt mode with rendering the original article per item row. The item row height is set to a fixed value to don't mess up the scroll and for screen readers the item row height doesn't matter Signed-off-by: Wolfgang <github@linux-dude.de>
|
Since these are settings and not data, I don't know if it's possible. I also wouldn't mind people having to configure settings one more time. It's not that complicated |
…tend use the nextcloud api for loading/saving settings Signed-off-by: Wolfgang <github@linux-dude.de>
sounds good, regarding the unit tests, is /settings still needed. Because the new frontend uses the nextcloud api I think we need new unit tests here. |
|
If it doesn't use that API I think we can remove it. |
Signed-off-by: Wolfgang <github@linux-dude.de>
SMillerDev
approved these changes
Dec 1, 2024
Grotax
added a commit
that referenced
this pull request
Dec 1, 2024
Changed - add region role to content list and details so that it can be used by screen readers (#2946) - split display settings in "display mode" and "split mode" to allow combining modes (#2950) - add display mode optimized for screen readers (#2950) Fixed - use appropriate semantic HTML elements for the item list to be recognised by screen readers (#2946) - make title in item list clickable for screen readers to select the current item (#2946) - remove mime type check when importing `opml`, they are not reliable anyway (#2951) - Embedded images are all scaled to max (#2945) - If an article doesn't have title, there's no link to the article (#758) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Dec 1, 2024
Changed - add region role to content list and details so that it can be used by screen readers (#2946) - split display settings in "display mode" and "split mode" to allow combining modes (#2950) - add display mode optimized for screen readers (#2950) Fixed - use appropriate semantic HTML elements for the item list to be recognised by screen readers (#2946) - make title in item list clickable for screen readers to select the current item (#2946) - remove mime type check when importing `opml`, they are not reliable anyway (#2951) - Embedded images are all scaled to max (#2945) - If an article doesn't have title, there's no link to the article (#758) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the current display options and adds a screen reader optimized mode
This are the new settings:
display mode: default, compact, screenreader
split mode: vertical, horizontal, off
The screen reader mode uses a single column layout with rendering the original article in the list.
This PR needs to convert the old expand/compactExpand settings:
compact 0 -> displaymode 0, splitmode 0
compact 1, compactExpand 0 -> displaymode 1, splitmode 0
compact 1, compactExpand 1 -> displaymode 1, splitmode 1
@SMillerDev @Grotax where can I find how the conversion should be made?
Checklist