-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show red error bubble only if more than 50 updates failed. #2955
Conversation
Even if this was the standard in News 24, I think 50 is too high. What is your experience with your faulty services? What "high" numbers do you see for your feeds with download errors? |
You're right. I'd say 10 would be a good choice. Any other opinions?
The error counters for temporary faulty services I've seen were less than 5. |
I would than go with 8 or 10, that seems reasonable values to me. |
c3cabec
to
868c195
Compare
This restores v24's behavior that hasn't been implemented in v25. Signed-off-by: Andreas Mair <amair.sob@gmail.com>
Changed - Show red error bubble only if more than 8 updates fail. (#2955) - Emulate structural heading navigation in screen reader mode with the jump to previous/next articles keys (#2978) - Add `PageDown` and `PageUp` for article heading navigation in screen reader mode (#2978) Fixed - set correct input focus when opening `AddFeed` or `Share` modals (#2965) - add item url to open website button aria label for screen readers (#2965) - allow using `toggle starred` and `mark read` icons with keyboard (#2965) - remove close button from list items in screen reader mode (#2965) - mark read on scroll marks visible items as read using vertical compact display mode (#2965) - Items read on other devices do not disappear on pressing 'r' (#2981) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Changed - Show red error bubble only if more than 8 updates fail. (#2955) - Emulate structural heading navigation in screen reader mode with the jump to previous/next articles keys (#2978) - Add `PageDown` and `PageUp` for article heading navigation in screen reader mode (#2978) Fixed - set correct input focus when opening `AddFeed` or `Share` modals (#2965) - add item url to open website button aria label for screen readers (#2965) - allow using `toggle starred` and `mark read` icons with keyboard (#2965) - remove close button from list items in screen reader mode (#2965) - mark read on scroll marks visible items as read using vertical compact display mode (#2965) - Items read on other devices do not disappear on pressing 'r' (#2981) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
This restores v24's behavior that hasn't been implemented in v25.
Summary
Before release 25 there had to be more than 50 feed update errors so that a feed was marked. In v25 every single update error results in a red marking which can be annoying as everybody knows that download errors can happen now and then.
Checklist