Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show red error bubble only if more than 50 updates failed. #2955

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

a-mair
Copy link
Contributor

@a-mair a-mair commented Dec 1, 2024

This restores v24's behavior that hasn't been implemented in v25.

Summary

Before release 25 there had to be more than 50 feed update errors so that a feed was marked. In v25 every single update error results in a red marking which can be annoying as everybody knows that download errors can happen now and then.

Checklist

src/components/Sidebar.vue Outdated Show resolved Hide resolved
@wofferl
Copy link
Collaborator

wofferl commented Dec 2, 2024

Even if this was the standard in News 24, I think 50 is too high.
Not knowing for 50 hours that you won't get any more news for a feed is a long time.
I would personally prefer a smaller value like ten or even less.
A flapping service should recover between ten update cycles and it should be long enough for maintenace windows on the feed side.

What is your experience with your faulty services? What "high" numbers do you see for your feeds with download errors?

@a-mair
Copy link
Contributor Author

a-mair commented Dec 2, 2024

Even if this was the standard in News 24, I think 50 is too high. Not knowing for 50 hours that you won't get any more news for a feed is a long time. I would personally prefer a smaller value like ten or even less. A flapping service should recover between ten update cycles and it should be long enough for maintenace windows on the feed side.

You're right. I'd say 10 would be a good choice. Any other opinions?

What is your experience with your faulty services? What "high" numbers do you see for your feeds with download errors?

The error counters for temporary faulty services I've seen were less than 5.

@wofferl
Copy link
Collaborator

wofferl commented Dec 2, 2024

Even if this was the standard in News 24, I think 50 is too high. Not knowing for 50 hours that you won't get any more news for a feed is a long time. I would personally prefer a smaller value like ten or even less. A flapping service should recover between ten update cycles and it should be long enough for maintenace windows on the feed side.

You're right. I'd say 10 would be a good choice. Any other opinions?

What is your experience with your faulty services? What "high" numbers do you see for your feeds with download errors?

The error counters for temporary faulty services I've seen were less than 5.

I would than go with 8 or 10, that seems reasonable values to me.

@a-mair a-mair force-pushed the error-counter branch 2 times, most recently from c3cabec to 868c195 Compare December 4, 2024 18:40
This restores v24's behavior that hasn't been implemented in v25.

Signed-off-by: Andreas Mair <amair.sob@gmail.com>
@wofferl wofferl merged commit f7ab264 into nextcloud:master Dec 9, 2024
22 of 24 checks passed
Grotax added a commit that referenced this pull request Dec 16, 2024
Changed
- Show red error bubble only if more than 8 updates fail. (#2955)
- Emulate structural heading navigation in screen reader mode with the jump to previous/next articles keys (#2978)
- Add `PageDown` and `PageUp` for article heading navigation in screen reader mode (#2978)

Fixed
- set correct input focus when opening `AddFeed` or `Share` modals (#2965)
- add item url to open website button aria label for screen readers (#2965)
- allow using `toggle starred` and `mark read` icons with keyboard (#2965)
- remove close button from list items in screen reader mode (#2965)
- mark read on scroll marks visible items as read using vertical compact display mode (#2965)
- Items read on other devices do not disappear on pressing 'r' (#2981)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Dec 16, 2024
Grotax added a commit that referenced this pull request Dec 16, 2024
Changed
- Show red error bubble only if more than 8 updates fail. (#2955)
- Emulate structural heading navigation in screen reader mode with the jump to previous/next articles keys (#2978)
- Add `PageDown` and `PageUp` for article heading navigation in screen reader mode (#2978)

Fixed
- set correct input focus when opening `AddFeed` or `Share` modals (#2965)
- add item url to open website button aria label for screen readers (#2965)
- allow using `toggle starred` and `mark read` icons with keyboard (#2965)
- remove close button from list items in screen reader mode (#2965)
- mark read on scroll marks visible items as read using vertical compact display mode (#2965)
- Items read on other devices do not disappear on pressing 'r' (#2981)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants