Show error message received from the API when adding feed #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wolfgang <github@linux-dude.de>
…eed could not be added Signed-off-by: Wolfgang <github@linux-dude.de>
Signed-off-by: Wolfgang <github@linux-dude.de>
… shown to the api client Signed-off-by: Wolfgang <github@linux-dude.de>
SMillerDev
approved these changes
Dec 18, 2024
Grotax
added a commit
that referenced
this pull request
Dec 22, 2024
Changed - show error message in add feed dialog and keep it open if the feed could not be added (#2988) - keep margins the same even if an article does not use max width (#2995) Fixed - adding feed via web-ui always use auto-discover (#2988) - show 403 forbidden errors when fetching feeds (#2988) - prevent move feed dialog from being closed unexpectedly (#2995) - don't abort `opml` import when a single feed exists or can't be added (#2996) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Dec 22, 2024
Changed - show error message in add feed dialog and keep it open if the feed could not be added (#2988) - keep margins the same even if an article does not use max width (#2995) Fixed - adding feed via web-ui always use auto-discover (#2988) - show 403 forbidden errors when fetching feeds (#2988) - prevent move feed dialog from being closed unexpectedly (#2995) - don't abort `opml` import when a single feed exists or can't be added (#2996) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add an error message to the add feed dialog to show what happens if a feed can't be added.
It also adds error handling to the backend for 403 forbidden errors and errors during auto-discover to give the user reasonable information in the server log and in the web-ui.
Checklist