Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category: Add new category button to create new folders #1002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

theatischbein
Copy link
Contributor

Following #967 I added an action in the navigation item Categories for adding new folders in the current notes path acting as categories.

Some remarks:

This gifs show the workflow and an error case, if a folder with that name already exist (but may not listed in categories if the folder is empty)

ezgif com-video-to-gif

@juliushaertl
Copy link
Member

I used the remote.php api end-point like the files app, but I am unsure if there is a more elegant way nextcloud/server@55ba960/apps/files/src/utils/davUtils.js

I wanted to use NcActionInput like the calendar app, but I had trouble to get the trailing submit arrow working, because it only works if the value isn't empty at rendering.. nextcloud/nextcloud-vue@c269d6a/src/components/NcActionInput/NcActionInput.vue#L221

Maybe we can Have a separate clear category button? Otherwise I could imagine this would be good to fix upstream in the library in a follow up.

The Category list does not display empty folder, after creating a category I seleted it so that the success is visible, but if no note is added, the category will vanished from the list until a note is added this category
Opening the add menu is possible without expanding the category list (just shown in gif differently)

Seems reasonable, I don#t think there is need for any separate API here if we can use standard webdav.
Thanks a lot for the pull request. I think this could need some design input from @nimishavijay and @jancborchardt in terms of handling the categories without notes. From my perspective we should probably consider changing that behaviour to also show empty categories (which are just folders in the end).

The category list will count wills in folder even they are not matching the select file suffix

I think this would be ok, we might want to discuss separately how we handle different file extensions with the new rich editor, especially if .txt files should rather be opened in plain text editing mode rather than also markdown.

@juliushaertl
Copy link
Member

Just noticed that showing all categories is at least an option as part of the 3-column layout in 4412195

@juliushaertl juliushaertl added enhancement New feature or request needs discussion Need to clarify if and how we should implement this design Related to the design or user experience labels Apr 13, 2023
@theatischbein theatischbein mentioned this pull request Apr 15, 2023
@jancborchardt
Copy link
Member

Just noticed that showing all categories is at least an option as part of the 3-column layout in 4412195

Yeah, we could simply also show categories without notes in them, that is fine. If the folder exists it should be shown. :)

And design-wise yep, this depends a bunch on the 3-column layout. With the switch to that, we don’t need this whole expand and collapse mechanic anymore, as the folder/category list is the only thing in the left navigation.

@theatischbein
Copy link
Contributor Author

Another ping here @juliushaertl does this need to await the redesign to the 3 column layout ?

Are they any open tasks that I can implemend here ?

@juliushaertl
Copy link
Member

We merged the three column layout end of last week, i think this change would be a great addition to rebase on top.

Regarding other tasks it mostly depends on your interest, we are generally open to any feature contribution, if there is an issue if of course might make sense to discuss ideas first to also align with our designers about potential UX topics.

We also have a chatroom for contributors on our Nextcloud instance, in case you are interested in joining for some exchange feel free to drop me an email to julius at nextcloud.com then I'd be glad to send you an invite.

theatischbein and others added 2 commits November 7, 2023 15:12
notes path for categories.

Signed-off-by: Jonathan Pagel <jonny_tischbein@systemli.org>
@juliushaertl
Copy link
Member

I also gave this a rebase and during that adjusted the positioning of the new category button which could now be located right next to the section header:

Screenshot 2023-11-07 at 15 49 39

The main missing part would be to properly handle displaying the new category in the list now.

@juliushaertl juliushaertl mentioned this pull request Nov 15, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to the design or user experience enhancement New feature or request needs discussion Need to clarify if and how we should implement this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants