Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add license headers in missing files #1906

Merged
merged 2 commits into from
Apr 29, 2024
Merged

chore: Add license headers in missing files #1906

merged 2 commits into from
Apr 29, 2024

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Apr 29, 2024
@nickvergessen nickvergessen self-assigned this Apr 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8551 was 8200 (+4.28%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

Antreesy
Antreesy approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, not sure about CI here

@nickvergessen
Copy link
Member Author

/compile /

@nickvergessen
chore: Add license headers in missing files
5350460 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore(assets): Recompile JS
c779a77 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8550 was 8200 (+4.26%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit ecc1c0b into master Apr 29, 2024
41 checks passed
@nickvergessen nickvergessen deleted the chore/spdx branch April 29, 2024 11:01
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Antreesy