Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browser): Don't create web notifications for old notifications #1943

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix(browser): Don't create web notifications for old notifications #1943

merged 2 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. fix(browser): Don't create web notifications for old notifications 

    Sometimes a notification got "newly mounted" while being old.
This can happen when a user has many notifications (100-1).
The UI first only loads (100-76), if any notification is then
resolved (e.g. by deleting or reading a chat), further old
notifications (75+74) would be added to the UI and triggered
a web notification (including call sound) in the past.

This threshold ID is therefore updated to only higher values,
before each pulling of notifications to ensure that we only ever
web-notify on new notifications and not newly loaded old
notifications.

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    6a54367 View commit details
    Browse the repository at this point in the history

  2. chore(assets): Recompile assets 

    Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
    @nextcloud-command
    nextcloud-command committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    227b208 View commit details
    Browse the repository at this point in the history