-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow devices to register for push notifications #59
Conversation
620d573
to
e9ab32a
Compare
@nickvergessen What is the status of this? Is there any ETA? |
Device registration is done, next task is the actual pushing. I plan to do the specs this week and finish the implementation next week. |
@nickvergessen What is the status of this? |
Functionality-wise its done, waiting for feedback from marino |
@nickvergessen @marinofaggiana What is the feedback? Does it work on your side, @marinofaggiana ? |
No, this is the error for https://push-notifications.nextcloud.com since 15.03 : Printing description of error: |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
To stay compatible with the Golang implementation here we return raw bytes and also don't hash twice. Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@marinofaggiana @mario I had a typo, so the URLs changed, it's Availability can be checked via capabilities now: |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
I fixed the OCS response, it now correctly contains the ocs and data elements. |
mmm but the protocol API is the same ... I think ... ? |
Yeah, its just: {
"ocs": {
"meta": {
"status": "ok",
"statuscode": 201,
"message": "OK"
},
"data": {
"publicKey": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxzY+\/0F2C1fzVVjHQTaX\nzOYXuT26sEAJmMEx9nUjdU5CNfLN5QsXQigluKHOZn3YV4D8PR\/A5x1394C+PpGG\nEQ0G\/61ATwZi+d+BCP\/Ep4ftmfiZQx9btMY6fG4jqzKUDmEp3iRceBK6WWuPvNvw\nv9m9CqmZoJjgFYtcfMxfG3ZTXYMrArGTYoy6nxLE8aU1Eo8YfNcu12dvBXJemEIF\nd2KNjBfmrY7\/aZ0v2P+PtFCNuSvC2rwm50sOZnfWV6Ve3kJlPu+VHM93mzXjy8ZS\n2zg\/0CA1KKpADg6uEquVMuSMWM6YJmSr7gaGZQowRtdiZQb90bhEIWLko+k1FmmG\nEwIDAQAB\n-----END PUBLIC KEY-----\n",
"deviceIdentifier": "bX+fVPw0rCUv8QHNjMqrPF1aqKv16UN5QC\/oiC4aq7ChV0vDUcLvAwbmxYmNUYygsxEF6+ddnPpIDaoNlyMqDQ==",
"signature": "CZgGR+dCpsRBv5qWIjuOW4qCOs13TZJfmbkIs4CUIb92VajpJdl7D4zBZVGzZ7XSDDIBtilATEMuuimuecZ8bZD9v6EQEw7q4ySuvyMJROSeo4OfcRyMpSrkpK8F8br8txm3U6ML\/DtvTzAX8f8mKVe32+0sBEbXI+RmXAeXypYyNPC3KXHjWyQkaPG1c1TQAoJafTZhw1OJav\/vrks9sNG6CqSkyJ3JHcW3+2oqOtEpm7hxW3IzAFTxUCI2nn3mEp7unVzBXwZkpcYP+BX4HD53J74WleRFWUbnx9QrNzXxi457jOH9UXiPfKNLvbn5XVTAOPefpgHnOC+wCc3OkA=="
}
}
} instead of: {
"publicKey": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxzY+\/0F2C1fzVVjHQTaX\nzOYXuT26sEAJmMEx9nUjdU5CNfLN5QsXQigluKHOZn3YV4D8PR\/A5x1394C+PpGG\nEQ0G\/61ATwZi+d+BCP\/Ep4ftmfiZQx9btMY6fG4jqzKUDmEp3iRceBK6WWuPvNvw\nv9m9CqmZoJjgFYtcfMxfG3ZTXYMrArGTYoy6nxLE8aU1Eo8YfNcu12dvBXJemEIF\nd2KNjBfmrY7\/aZ0v2P+PtFCNuSvC2rwm50sOZnfWV6Ve3kJlPu+VHM93mzXjy8ZS\n2zg\/0CA1KKpADg6uEquVMuSMWM6YJmSr7gaGZQowRtdiZQb90bhEIWLko+k1FmmG\nEwIDAQAB\n-----END PUBLIC KEY-----\n",
"deviceIdentifier": "bX+fVPw0rCUv8QHNjMqrPF1aqKv16UN5QC\/oiC4aq7ChV0vDUcLvAwbmxYmNUYygsxEF6+ddnPpIDaoNlyMqDQ==",
"signature": "CZgGR+dCpsRBv5qWIjuOW4qCOs13TZJfmbkIs4CUIb92VajpJdl7D4zBZVGzZ7XSDDIBtilATEMuuimuecZ8bZD9v6EQEw7q4ySuvyMJROSeo4OfcRyMpSrkpK8F8br8txm3U6ML\/DtvTzAX8f8mKVe32+0sBEbXI+RmXAeXypYyNPC3KXHjWyQkaPG1c1TQAoJafTZhw1OJav\/vrks9sNG6CqSkyJ3JHcW3+2oqOtEpm7hxW3IzAFTxUCI2nn3mEp7unVzBXwZkpcYP+BX4HD53J74WleRFWUbnx9QrNzXxi457jOH9UXiPfKNLvbn5XVTAOPefpgHnOC+wCc3OkA=="
} |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
d62fff8
to
3a75592
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke any chance you can try to test this? |
When you give me the rough steps to do so;) |
@mario @nickvergessen Could you explain how the complete flow works and what needs to be setup to work properly and how the whole setup works. |
I sent you a mail |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Merging for 12, after speaking to @MorrisJobke |
🙈 |
ToDos