prefix redis channels with redis db id #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #127 Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
redis-prefix
branch
from
94df509
to
3ddf102
Compare
|
Any news on that PR? What’s preventing the merge? |
ldidry
reviewed
Jan 17, 2024
| @@ -34,7 +34,7 @@ public function __construct($redis) { | |||
| } | |||
|
|
|||
| public function push(string $channel, $message) { | |||
| $this->redis->publish($channel, json_encode($message)); | |||
| $this->redis->publish($this->redis->getDbNum() . '_' . $channel, json_encode($message)); | |||
There was a problem hiding this comment.
You shouldn't use the database number as a discriminator because if you're using a Redis cluster, there's only one database. Instead, you should use NEXTCLOUD_URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #127
Signed-off-by: Robin Appelman robin@icewind.nl