-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies + move to sqlx-oldapi for now #383
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
https://github.com/nextcloud/notify_push/actions/runs/7613758006/job/20734418222?pr=383 looks like rustc is too old:
I was able to fix a similar failure by using nix 23.11 instead here: 8d47bc8 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems like a good approach to be able to update the dependencies fast. First pass over the code changes looks good as well. Did not test locally though.
Signed-off-by: Robin Appelman <robin@icewind.nl>
530d8bf
to
1b95066
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 I ran the tests and clippy locally again and everything is green. So good to go from my side. Anything else needed? |
sqlx 0.7 still has some issues which are blocking for us (launchbadge/sqlx#2975) so instead this moves to sqlx-oldapi for now which is a fork of 0.6 with some dependency updates.
Fixes #354