Do not use libxml_disable_entity_loader on PHP 8 or later #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
techdebt/libxml_disable_entity_loader
branch
from
df9f0fb
to
41badce
Compare
Raudius
approved these changes
Apr 13, 2022
vinicius73
reviewed
Apr 13, 2022
Co-authored-by: Vinicius Reis <luiz.vinicius73@gmail.com>
delete-merged-branch
bot
deleted the
techdebt/libxml_disable_entity_loader
branch
|
Hi there! errors ever since upgrading to NC22 and PHP 8.0 (currently on NC23 with OfficeOnline app v1.1.3). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid deprecation logs on PHP 8
https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation
Cherry-pick of nextcloud/richdocuments#1502 for the office online integration