Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from app.php to IBootstrap #462

Closed
wants to merge 1 commit into from
Closed

Migrate from app.php to IBootstrap #462

wants to merge 1 commit into from

Conversation

patschi
Copy link
Member

@patschi patschi commented Jul 21, 2023

  • Resolves: #
  • Target version: main

Summary

Migrated from app.php to IBootstrap. Tested:

  1. App is loaded
  2. Settings can be changed
  3. Documents can be opened

My PHP might be a bit rusty and PHP as well as Nextcloud seems to be evolving quite quickly - please check the commit thoroughly and let me know about any feedback.

Fixes #353

TODO

n/a

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Patrik Kernstock <patrik@kernstock.net>
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for your pull request and also the cleanup work on the issues. Looks good code wise but will give it a test run myself later this week.

@patschi
Copy link
Member Author

patschi commented Jul 25, 2023

Looks good code wise but will give it a test run myself later this week.

Thanks for checking so quick. I also tried to get seemingly simpler issues implemented - like OneNote support, what OOS can out-of-the-box. However the WOPI protocol and Office Online is such awful to troubleshoot, that I failed miserably after a few hours.

--
Related: nextcloud/server#32132

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@joshtrichards
Copy link
Member

Superseded by #490. Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Officeonline App "/appinfo/app.php is deprecated"
3 participants