chore: Resolve psalm warnings

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

psalm.xml

@@ -1,5 +1,8 @@
 <?xml version="1.0"?>
-<psalm errorLevel="4" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+<psalm errorLevel="4"
+	findUnusedBaselineEntry="true"
+	findUnusedCode="false"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 	xmlns="https://getpsalm.org/schema/config"
 	xsi:schemaLocation="https://getpsalm.org/schema/config https://getpsalm.org/schema/config"
 	errorBaseline="tests/psalm-baseline.xml"

tests/psalm-baseline.xml

@@ -1,54 +1,45 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="4.29.0@7ec5ffbd5f68ae03782d7fd33fff0c45a69f95b3">
+<files psalm-version="5.25.0@01a8eb06b9e9cc6cfb6a320bf9fb14331919d505">
   <file src="lib/Controller/AlbumsController.php">
-    <UndefinedClass occurrences="2">
-      <code>SharedStorage</code>
-      <code>\OCA\GroupFolders\Mount\GroupFolderStorage</code>
+    <UndefinedClass>
+      <code><![CDATA[SharedStorage]]></code>
+      <code><![CDATA[\OCA\GroupFolders\Mount\GroupFolderStorage]]></code>
     </UndefinedClass>
   </file>
   <file src="lib/Controller/PreviewController.php">
-    <UndefinedDocblockClass occurrences="4">
-      <code>OCA\Files_Sharing\SharedStorage</code>
-    </UndefinedDocblockClass>
-    <UndefinedClass occurrences="1">
-      <code>SharedStorage</code>
+    <UndefinedDocblockClass/>
+    <UndefinedClass>
+      <code><![CDATA[SharedStorage]]></code>
     </UndefinedClass>
   </file>
   <file src="lib/Controller/PageController.php">
-    <InvalidArgument occurrences="1">
-      <code>new SearchQuery(new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'systemtag',
-        $tag-&gt;getName()), 0, 0, [], $user)</code>
-    </InvalidArgument>
-
-    <UndefinedClass occurrences="12">
-      <code>$e</code>
-      <code>LoadSidebar</code>
-      <code>LoadSidebar</code>
-      <code>LoadViewer</code>
-      <code>LoadViewer</code>
-      <code>NoUserException</code>
-      <code>SearchBinaryOperator</code>
-      <code>SearchComparison</code>
-      <code>SearchComparison</code>
-      <code>SearchComparison</code>
-      <code>SearchQuery</code>
-      <code>SearchQuery</code>
+    <UndefinedClass>
+      <code><![CDATA[$e]]></code>
+      <code><![CDATA[LoadViewer]]></code>
+      <code><![CDATA[LoadViewer]]></code>
+      <code><![CDATA[NoUserException]]></code>
+      <code><![CDATA[SearchBinaryOperator]]></code>
+      <code><![CDATA[SearchComparison]]></code>
+      <code><![CDATA[SearchComparison]]></code>
+      <code><![CDATA[SearchComparison]]></code>
+      <code><![CDATA[SearchQuery]]></code>
+      <code><![CDATA[SearchQuery]]></code>
     </UndefinedClass>
   </file>
   <file src="lib/Controller/PublicAlbumController.php">
-    <UndefinedClass occurrences="2">
-      <code>LoadViewer</code>
-      <code>LoadViewer</code>
+    <UndefinedClass>
+      <code><![CDATA[LoadViewer]]></code>
+      <code><![CDATA[LoadViewer]]></code>
     </UndefinedClass>
   </file>
   <file src="lib/AppInfo/Application.php">
-    <InvalidArgument occurrences="9">
-      <code>registerEventListener</code>
+    <InvalidArgument>
+      <code><![CDATA[registerEventListener]]></code>
     </InvalidArgument>
   </file>
   <file src="lib/Listener/SabrePluginAuthInitListener.php">
-    <UndefinedMethod occurrences="1">
-      <code>addBackend</code>
+    <UndefinedMethod>
+      <code><![CDATA[addBackend]]></code>
     </UndefinedMethod>
   </file>
-</files>
+</files>

vendor-bin/psalm/composer.json

@@ -1,8 +1,8 @@
 {
-    "require-dev": {
-        "psalm/phar": "^5.25",
-        "nextcloud/ocp": "dev-master",
-        "symfony/console": "^5.4.24",
-        "sabre/dav": "^4.4.0"
-    }
+	"require-dev": {
+		"psalm/phar": "^5.25",
+		"nextcloud/ocp": "dev-master",
+		"symfony/console": "^5.4.24",
+		"sabre/dav": "^4.4.0"
+	}
 }