Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect .noimage and .nomedia files #159

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jan 27, 2020

Fixes #75

When a folder has a .noimage or .nomedia node. Just don't show the
folder in the album overview. Ignore it and do not traverse it.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes #75

When a folder has a .noimage or .nomedia node. Just don't show the
folder in the album overview. Ignore it and do not traverse it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer requested a review from skjnldsv January 27, 2020 08:00
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement New feature or request feature: albums Related to the albums section labels Jan 27, 2020
@skjnldsv
Copy link
Member

Of course it still won't work for the timeline, I wonder if I can do it with dav search 🤔

@skjnldsv
Copy link
Member

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 27, 2020
@skjnldsv skjnldsv merged commit cec404e into master Jan 27, 2020
@skjnldsv skjnldsv deleted the fix/75/hige_noimage_folders_in_album_overview branch January 27, 2020 08:02
@backportbot-nextcloud
Copy link

backport to stable18 in #160

@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Jan 27, 2020
@rullzer
Copy link
Member Author

rullzer commented Jan 27, 2020

Of course it still won't work for the timeline, I wonder if I can do it with dav search thinking

Not really.

@Mikescops
Copy link
Member

@skjnldsv if we add the ability to select the folders for the timeline, it will be fine

@skjnldsv
Copy link
Member

@skjnldsv if we add the ability to select the folders for the timeline, it will be fine

I guess it's a nice workaround yes :)

@newhinton
Copy link

@skjnldsv is this feature for the timeline planned? I tried 1.1.0 and for albums it works flawles, but not for the timeline (as expected). But honestly, the timeline should also check for that. Is there anything i could do? Also, is there a seperate issue for the timeline?

@skjnldsv
Copy link
Member

skjnldsv commented Mar 9, 2020

@newhinton that is a good question!
Is is technically possible, no idea :)
There is also #141 which is for the timeline.

But I'm not sure I can exclude path containing nomedia/noimages while doing a dav SEARCH. Any idea?
I could search for all nomedia/noimages and then exclude those paths from the main SEARCH I guess :)
Not sure how it scale though 🤔

EDIT: #141 not #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: albums Related to the albums section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not taking into account the .noimage flag
4 participants