Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sharing with group #1600

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Conversation

simonspa
Copy link

@simonspa simonspa commented Jan 22, 2023

This MR fixes adding photos to an album shared to a group of users. The essential problem was that only collaboration via userId was checked.

This adds a new method to AlbumMapper to check for any given user ID of the user is a collaborator, no matter whether this is via direct sharing or group sharing.

This fixes #1596

@simonspa simonspa requested a review from artonge January 22, 2023 15:08
@simonspa simonspa added bug Something isn't working 3. to review Waiting for reviews labels Jan 22, 2023
@szaimen szaimen added this to the Nextcloud 26 milestone Jan 22, 2023
lib/Album/AlbumMapper.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Simon Spannagel added 6 commits January 24, 2023 07:13
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
@artonge artonge merged commit cb6acf8 into nextcloud:master Jan 24, 2023
@simonspa
Copy link
Author

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 24, 2023
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Sharing Albums with Groups Doesn't Work
3 participants