-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sharing with group #1600
Merged
Merged
Fix sharing with group #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonspa
force-pushed
the
p/fix-group-sharing
branch
from
January 22, 2023 15:15
0f8a9f7
to
9c40bea
Compare
artonge
reviewed
Jan 23, 2023
artonge
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
Signed-off-by: Simon Spannagel <simonspa@kth.se>
simonspa
force-pushed
the
p/fix-group-sharing
branch
from
January 24, 2023 06:14
b27ba86
to
f3365d9
Compare
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
Pending backport by the backport-bot
label
Jan 24, 2023
backportbot-nextcloud
bot
removed
the
backport-request
Pending backport by the backport-bot
label
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes adding photos to an album shared to a group of users. The essential problem was that only collaboration via
userId
was checked.This adds a new method to
AlbumMapper
to check for any given user ID of the user is a collaborator, no matter whether this is via direct sharing or group sharing.This fixes #1596