Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(a11y): Fix heading hierarchy in some places #2272

Merged
merged 2 commits into from
Feb 2, 2024
+120 −60
Merged

[stable28] fix(a11y): Fix heading hierarchy in some places #2272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0face99
fix(a11y): Fix heading hierarchy in some places
Pytal Jan 19, 2024
858da42
chore(assets): Recompile assets
nextcloud-command Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Faces/FaceCover.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
</div>
<div class="face-cover__details">
<div v-if="!baseName.match(/^[0-9]+$/)" class="face-cover__details__first-line">
<h2 class="face-cover__details__name">
<span class="face-cover__details__name">
{{ baseName }}
</h2>
</span>
</div>
<div v-if="!small" class="face-cover__details__second-line">
{{ n('photos', '%n photos', '%n photos', face.props['nbItems']) }}
Expand Down Expand Up @@ -82,7 +82,7 @@
]),

/**
* @return {Face}

Check warning on line 85 in src/components/Faces/FaceCover.vue

View workflow job for this annotation

GitHub Actions / eslint 

The type 'Face' is undefined
*/
face() {
return this.faces[this.baseName]
Expand Down
6 changes: 5 additions & 1 deletion src/mixins/FaceCover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@
&__name {
flex-grow: 1;
margin: 0;
font-weight: bold;
font-size: 20px;
line-height: 30px;
color: var(--color-main-text);
}
}
}
Expand All @@ -87,4 +91,4 @@
height: 60px !important;
--photos-face-width: 60px !important;
}
}
}
8 changes: 6 additions & 2 deletions src/views/Albums.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
:link="`/albums/${collection.basename}`"
:alt-img="t('photos', 'Cover photo for album {albumName}', { albumName: collection.basename })"
:cover-url="collection.lastPhoto | coverUrl">
<h2 class="album__name">
<span class="album__name">
{{ collection.basename }}
</h2>
</span>

<div slot="subtitle" class="album__details">
{{ collection.date }} ⸱ {{ n('photos', '%n item', '%n photos and videos', collection.nbItems,) }}
Expand Down Expand Up @@ -160,6 +160,10 @@ export default {
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
font-size: 20px;
margin-bottom: 12px;
line-height: 30px;
color: var(--color-main-text);
}
}

Expand Down
8 changes: 6 additions & 2 deletions src/views/Places.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
:link="`/places/${collection.basename}`"
:alt-img="t('photos', 'Cover photo for place {placeName}', { placeName: collection.basename })"
:cover-url="collection.lastPhoto | coverUrl">
<h2 class="place__name">
<span class="place__name">
{{ collection.basename }}
</h2>
</span>

<div slot="subtitle" class="place__details">
{{ n('photos', '%n item', '%n photos and videos', collection.nbItems,) }}
Expand Down Expand Up @@ -127,6 +127,10 @@ export default {
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
font-size: 20px;
margin-bottom: 12px;
line-height: 30px;
color: var(--color-main-text);
}
}
</style>
8 changes: 6 additions & 2 deletions src/views/SharedAlbums.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
:alt-img="t('photos', 'Cover photo for shared album {albumName}.', { albumName: collection.basename })"
:data-test="collection.basename"
:cover-url="collection.lastPhoto | coverUrl">
<h2 class="album__name">
<span class="album__name">
{{ collection | albumOriginalName }}
</h2>
</span>

<div slot="subtitle" class="album__details">
{{ collection.date }} ⸱ {{ n('photos', '%n item', '%n photos and videos', collection.nbItems,) }}
Expand Down Expand Up @@ -140,6 +140,10 @@ export default {
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
font-size: 20px;
margin-bottom: 12px;
line-height: 30px;
color: var(--color-main-text);
}
}
</style>
Loading