Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Fix back arrow position in wide screens #2325

Merged
merged 2 commits into from
Feb 8, 2024
Merged

[stable28] Fix back arrow position in wide screens #2325

merged 2 commits into from
Feb 8, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 7, 2024 •
edited by JuliaKirschenheuter
Loading

Backport of #2324

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Feb 7, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.3 milestone Feb 7, 2024
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review February 8, 2024 07:58
@JuliaKirschenheuter
Copy link
Contributor

/compile /

@artonge @JuliaKirschenheuter
Fix back arrow position in wide screens
b1c2251 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@JuliaKirschenheuter JuliaKirschenheuter deleted the backport/2324/stable28 branch February 8, 2024 10:50
@JuliaKirschenheuter JuliaKirschenheuter restored the backport/2324/stable28 branch February 8, 2024 10:59
emoral435
emoral435 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on local dev, and works on both small screens and works as master branch does. The discrepancy in files seems to be not major 👍

firefox_8zsEen3qga

@JuliaKirschenheuter @artonge
chore(assets): Recompile assets
5df2d73 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@artonge artonge force-pushed the backport/2324/stable28 branch from 88d1c81 to 5df2d73 Compare February 8, 2024 13:43
@JuliaKirschenheuter JuliaKirschenheuter merged commit bea0661 into stable28 Feb 8, 2024
38 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the backport/2324/stable28 branch February 8, 2024 14:10
@skjnldsv skjnldsv mentioned this pull request Feb 14, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux Awaiting requested review from susnux

@artonge artonge Awaiting requested review from artonge

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Milestone
Nextcloud 28.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@JuliaKirschenheuter @emoral435 @artonge