Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(3rd-party apps): do not link to maps/recognize install page if the appstore isn't enabled #2428

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix(3rd-party apps): do not link to maps/recognize install page if the appstore isn't enabled #2428

merged 1 commit into from
Apr 15, 2024

Conversation

tcitworld
Copy link
Member

Even if the user is admin, they might not have access to the app store.

@tcitworld tcitworld added the 3. to review Waiting for reviews label Apr 12, 2024
@marcelklehr
Copy link
Member

Please make sure eslint passes, by separating || clauses from && clauses with parentheses.

@tcitworld tcitworld force-pushed the disable-links-to-install-apps-if-no-appstore branch from f2fcfb4 to 17d6bbd Compare April 12, 2024 16:25
@tcitworld
Copy link
Member Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the disable-links-to-install-apps-if-no-appstore branch from 17d6bbd to 0b11437 Compare April 12, 2024 16:37
artonge
artonge reviewed Apr 15, 2024
View reviewed changes
src/router/index.js Outdated Show resolved Hide resolved
@tcitworld
fix(3rd-party apps): do not link to maps/recognize install page if th…
4c2f100 
…e appstore isn't enabled

Even if the user is admin, they might not have access to the app store.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the disable-links-to-install-apps-if-no-appstore branch from 0b11437 to 4c2f100 Compare April 15, 2024 09:01
@tcitworld tcitworld requested a review from artonge April 15, 2024 09:14
@tcitworld tcitworld merged commit 7208122 into master Apr 15, 2024
44 checks passed
@tcitworld tcitworld deleted the disable-links-to-install-apps-if-no-appstore branch April 15, 2024 09:52
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcitworld @marcelklehr @artonge